Control: tags -1 + patch
Hi Michael,
On Sun, Feb 13, 2022 at 02:20:26PM +0100, Michael Biebl wrote:
> I suspect the following:
>
> in 1.0.0.rc16-10 /usr/lib/libdmraid.so is a dangling symlink to
> /lib/libdmraid.so.1.0.0.rc16 (yay for those pointless split-usr shenanigans,
> can we please have merged-usr like yesterday) and as a result the
> compiler/linker falls back to link
> /usr/lib/x86_64-linux-gnu/libdmraid.a
> statically into libblockdev-dm2
Thank you for the detailed analysis and for contacting me directly. I am
sorry for the inconvenience this bug has caused to you. I usually
double-check these links in a multiarch conversion, but it turns out
that both me and Laszlo missed this instance.
Before blindly applying this patch, let me propose something else:
We have this moratorium in place that says you should not move files
from / to /usr, because it could go bad when moving files. However, in
this case, we are moving files from non-triplet to triplet and thus we
can safely move from / to /usr without the aforementioned risk. So we
may want to go the extra mile here and use the multiarch-conversion to
move all files to /usr in a safe way for stable upgrades and get rid of
a pile of complexity that way.
That's up to Laszlo to decide. In the mean time, here is the patch that
fixes the issue reported by Lucas and diagnosed by Michael. Thank you
two.
Helmut
diff --minimal -Nru dmraid-1.0.0.rc16/debian/changelog
dmraid-1.0.0.rc16/debian/changelog
--- dmraid-1.0.0.rc16/debian/changelog 2022-02-03 17:28:13.000000000 +0100
+++ dmraid-1.0.0.rc16/debian/changelog 2022-02-14 17:43:28.000000000 +0100
@@ -1,3 +1,11 @@
+dmraid (1.0.0.rc16-10.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix bad library symlink (closes: #1005622). Thanks to Michael Biebl and
+ Lucas Nussbaum.
+
+ -- Helmut Grohne <hel...@subdivi.de> Mon, 14 Feb 2022 17:43:28 +0100
+
dmraid (1.0.0.rc16-10) unstable; urgency=medium
[ Johannes Schauer Marin Rodrigues <jo...@debian.org> ]
diff --minimal -Nru dmraid-1.0.0.rc16/debian/libdmraid-dev.links
dmraid-1.0.0.rc16/debian/libdmraid-dev.links
--- dmraid-1.0.0.rc16/debian/libdmraid-dev.links 2017-08-30
23:28:37.000000000 +0200
+++ dmraid-1.0.0.rc16/debian/libdmraid-dev.links 2022-02-14
17:41:24.000000000 +0100
@@ -1 +1,2 @@
-lib/libdmraid.so.1.0.0.rc16 usr/lib/libdmraid.so
+#!/usr/bin/dh-exec
+lib/${DEB_HOST_MULTIARCH}/libdmraid.so.1.0.0.rc16
usr/lib/${DEB_HOST_MULTIARCH}/libdmraid.so
diff --minimal -Nru dmraid-1.0.0.rc16/debian/rules
dmraid-1.0.0.rc16/debian/rules
--- dmraid-1.0.0.rc16/debian/rules 2022-02-03 17:28:13.000000000 +0100
+++ dmraid-1.0.0.rc16/debian/rules 2022-02-14 17:41:52.000000000 +0100
@@ -71,7 +71,6 @@
binary-arch: install
dh_testdir
dh_testroot
- chmod +x debian/libdmraid*.install
dh_install
dh_installdirs
dh_installudev --priority=97
