Hi Tom,
On 24 February 2022 at 20:49, Tom Lee wrote:
| Source: tiledb
| Version: 2.6.2
| Severity: important
| Tags: bookworm sid
| X-Debbugs-CC: tmanc...@debian.org
|
| Hi there,
|
| tiledb fails to build against capnproto 0.9.1, largely because of the
| hard-coded version number in the cmake modules. Attached is a patch that
| should allow tiledb to build against both 0.8.0 and 0.9.1 for the upcoming
| transition.
Nice, thank you. I presume you tested it?
Can you explain (to a cmake newb) the logic behind
++if (TILEDB_UPDATE_SERIALIZATION)
++ add_dependencies(tiledb_shared update-serialization)
++endif()
+ if (TILEDB_STATIC)
+ set_target_properties(tiledb_static
+ PROPERTIES
+ PUBLIC_HEADER "${TILEDB_PUBLIC_HEADERS}"
+ )
++ if (TILEDB_UPDATE_SERIALIZATION)
++ add_dependencies(tiledb_static update-serialization)
++ endif()
+ endif()
Why a second variable TILEDB_UPDATE_SERIALIZATION? To cover the 'yes well it
is 0.8.0 but you will live' case from allowing 0.9.1 in the new interval spec
'++set(TILEDB_CAPNPROTO_VERSION 0.8.0...0.9.1)' ?
Dirk
--
https://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
