On Mon, Feb 28, 2022 at 5:44 PM Santiago R.R. <santiag...@riseup.net> wrote: > > El 28/02/22 a las 16:26, Martin-Éric Racine escribió: > > > * You are moving stuff to /usr. Do you have any reason for making this > > > change in this NMU? > > > While I think it is a good thing, this is not documented in > > > d/changelog, and I think an NMU should focus on the reason for doing it > > > (the newest upstream release in this case). > > > From the developers reference (5.11.1.): "...Fixing cosmetic issues or > > > changing the packaging style in NMUs is discouraged." > > > > I try to keep the delta with upstream defaults as small as possible. > > Upstream uses /usr. The only thing that doesn't work as expected is > > that upstream's configure script fails at putting the prefix for > > manual pages. > > > > As a side-issue, Lintian incorrectly reports the upstream default for > > its lease database (/var/db) as non-standard. See Bug#1006482. Because > > of this, I've kept the directory unchanged for now. > > Sorry, just to be sure of understanding, are you reverting the move to > /usr? If yes, please tell me when you have a new version to review. > Otherwise, please document it in d/changelog.
Read again. Prefix is currently to upstream default at /usr. The DHCP lease database would be in /var/db/dhcpcd, but Lintian considers /var/db as non-standard even though it is FHS. Bug filed against Lintian accordingly and the lease database remains in /var/lib until Lintian has been fixed. > > > * Could you please fix the indentation of the your new entry in > > > d/copyright? > > > > IMHO, the whole file's indentation needs to be fixed. I had troubles > > aligning my addition, because the file currently uses TAB+2SPACES. > > There really should be a linting tool for that. > > Idem. Either I run wrap-and-sort on the source tree, or I make no attempt to fix the formatting of d/copyright. Martin-Éric
