Hello Simon,
Am Sat, Mar 12, 2022 at 05:02:37PM +0000 schrieb Simon McVittie:
...
> The attached patch for Thunderbird works, and gives me the expected
> result: Firefox doesn't ask to be made the default browser, and
> doesn't write itself into mimeapps.list as though it was Thunderbird.
>
> Please consider applying this in both unstable and stable: this bug is
> really confusing when it happens to a non-technical user.
thanks for inspecting and also for taking action on this issue!
Unfortunately I'm getting the following error while built Thunderbird
with your patch.
----%<----
/build/thunderbird-91.7.0/toolkit/system/gnome/nsGIOService.cpp:254:22: error:
cannot initialize a variable of type 'GAppLaunchContext *' (aka
'_GAppLaunchContext *') with an rvalue of type 'bool'
GAppLaunchContext* context = GetAppLaunchContext();
^ ~~~~~~~~~~~~~~~~~~~~~
/build/thunderbird-91.7.0/toolkit/system/gnome/nsGIOService.cpp:562:22: error:
cannot initialize a variable of type 'GAppLaunchContext *' (aka
'_GAppLaunchContext *') with an rvalue of type 'bool'
GAppLaunchContext* context = GetAppLaunchContext();
^ ~~~~~~~~~~~~~~~~~~~~~
/build/thunderbird-91.7.0/toolkit/system/gnome/nsGIOService.cpp:581:22: error:
cannot initialize a variable of type 'GAppLaunchContext *' (aka
'_GAppLaunchContext *') with an rvalue of type 'bool'
GAppLaunchContext* context = GetAppLaunchContext();
^ ~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
make[6]: *** [/build/thunderbird-91.7.0/config/rules.mk:676: nsGIOService.o]
Error 1
make[6]: Leaving directory
'/build/thunderbird-91.7.0/obj-thunderbird/toolkit/system/gnome'
make[5]: *** [/build/thunderbird-91.7.0/config/recurse.mk:72:
toolkit/system/gnome/target-objects] Error 2
make[5]: *** Waiting for unfinished jobs....
...
/build/thunderbird-91.7.0/obj-thunderbird/_virtualenvs/common/bin/python -m
mozbuild.action.check_binary --target --networking
/build/thunderbird-91.7.0/obj-thunderbird/x86_64-unknown-linux-gnu/release/libgkrust.a
BUILDTASK {"argv":
["/build/thunderbird-91.7.0/python/mozbuild/mozbuild/action/check_binary.py",
"--target", "--networking",
"/build/thunderbird-91.7.0/obj-thunderbird/x86_64-unknown-linux-gnu/release/libgkrust.a"],
"start": 1647367974.824636, "end": 1647367975.7637773, "context": null}
make[6]: Leaving directory
'/build/thunderbird-91.7.0/obj-thunderbird/toolkit/library/rust'
make[5]: Leaving directory '/build/thunderbird-91.7.0/obj-thunderbird'
make[4]: *** [/build/thunderbird-91.7.0/config/recurse.mk:34: compile] Error 2
make[4]: Leaving directory '/build/thunderbird-91.7.0/obj-thunderbird'
make[3]: *** [/build/thunderbird-91.7.0/config/rules.mk:355: default] Error 2
make[3]: Leaving directory '/build/thunderbird-91.7.0/obj-thunderbird'
dh_auto_build: error: cd obj-thunderbird && make -j6 returned exit code 2
----%>----
Looks a bit if some header is missing, but I've no deeper knowledge
about the internals of the source.
Regards
Carsten
