On Tue, 31 May 2022 12:38:21 -0300, Jesse Smith wrote:

> > I think what is happening here is that CFLAGS is not taken from the
> > Makefile but overridden from the Debian build machinery, so -DVERSION
> > (which would be 2.7) is not set/defined and VERSION is taken from
> > cpulimit.c and that still says 2.4.
> 
> It's easy enough to make the version numbers in cpulimit.c and Makefile
> match. 

Cool.

> Though that still leaves the interesting issue of why VERSION
> isn't being used by the Makefile. It sounds like Debian's build system
> is overwriting the CFLAGS variable, resulting in its own flags being used?

Right, that's what my guess above was about as well.

If you look at a build log, e.g. at
<https://buildd.debian.org/status/fetch.php?pkg=cpulimit&arch=amd64&ver=2.7-2&stamp=1636522237&raw=0>,
you see what's happening in detail:

cc -o cpulimit cpulimit.c -pthread -lrt -DLINUX -g -O2 
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now



Cheers,
gregor 

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   

Attachment: signature.asc
Description: Digital Signature

Reply via email to