Bug#1012574: ignition-msgs5: FTBFS with protobuf 3.20.1+

[GCS]

Source: ignition-msgs5
Version: 5.8.1+ds-2
Severity: important
Usertags: protobuf3_20
Tags: ftbfs upstream bookworm sid patch

Hi,

I would like to start the Protobuf 3.20.1 transition in a few days.
Your package is currently FTBFS for a simple reason. The function
SetTotalBytesLimit doesn't have a second argument for long (protobuf
3.6) and it was ignored previously. Now it's finally removed and hence
your package doesn't build anymore.
As it was ignored for a long time, the fix is easy, just remove that
argument when calling the mentioned function. Patch is attached,
please apply it soon.

Thanks,
Laszlo/GCS

Description: fix Protobuf FTBFS
 SetTotalBytesLimit no longer has second argument.
Author: Laszlo Boszormenyi (GCS) <g...@debian.org>
Forwarded: no
Last-Update: 2022-06-06

---

--- ignition-msgs5-5.8.1+ds.orig/src/Generator.cc
+++ ignition-msgs5-5.8.1+ds/src/Generator.cc
@@ -67,7 +67,7 @@ Generator::~Generator()
 
 /////////////////////////////////////////////////
 bool Generator::Generate(const FileDescriptor *_file,
-                               const string &/*_parameter*/,
+                               const std::string &/*_parameter*/,
                                OutputDirectory *_generatorContext,
                                std::string * /*_error*/) const
 {
--- ignition-msgs5-5.8.1+ds.orig/src/Generator.hh
+++ ignition-msgs5-5.8.1+ds/src/Generator.hh
@@ -44,9 +44,9 @@ class Generator : public CodeGenerator
   /// \param[in] _generatorContext Output directory.
   /// \param[in] _error Unused string value
   public: virtual bool Generate(const FileDescriptor *_file,
-              const string &_parameter,
+              const std::string &_parameter,
               OutputDirectory *_generatorContext,
-              string *_error) const;
+              std::string *_error) const;
 
   // private: GOOGLE_DISALLOW_EVIL_CONSTRUCTORS(Generator);
 };