Package: golang-github-pion-turn.v2
Version: 2.0.8-2
Severity: Serious
The package fails tests (see log of failing test below) when run on a
machine with limited network (in this case: Can only reach the
relevant APT repository server). This is a policy violation, which
says that package tests must only access local resources services that
were also spun up by the test. This tests tries to reach
stun1.l.google.com though. And fails with a nil pointer dereference...
=== RUN TestClientWithSTUN/SendBindingRequest
client_test.go:58:
Error Trace: client_test.go:58
Error: Received unexpected error:
all retransmissions failed for T/+GXOMeJz4c8ifu
Test: TestClientWithSTUN/SendBindingRequest
Messages: should succeed
--- FAIL: TestClientWithSTUN (7.81s)
--- FAIL: TestClientWithSTUN/SendBindingRequest (7.81s)
panic: runtime error: invalid memory address or nil pointer
dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x5cf212]
goroutine 7 [running]:
testing.tRunner.func1.2({0x5f8d40, 0x7b8d00})
/usr/lib/go-1.18/src/testing/testing.go:1389 +0x24e
testing.tRunner.func1()
/usr/lib/go-1.18/src/testing/testing.go:1392 +0x39f
panic({0x5f8d40, 0x7b8d00})
/usr/lib/go-1.18/src/runtime/panic.go:838 +0x207
github.com/pion/turn/v2.TestClientWithSTUN.func1(0x0?)
/<<PKGBUILDDIR>>/_build/src/github.com/pion/turn/v2/client_test.go:59 +0x152
testing.tRunner(0xc000109520, 0xc00002e2e0)
/usr/lib/go-1.18/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
/usr/lib/go-1.18/src/testing/testing.go:1486 +0x35f
FAIL github.com/pion/turn/v2 7.817s
? github.com/pion/turn/v2/examples/lt-cred-generator [no test files]
? github.com/pion/turn/v2/examples/turn-client/tcp [no test files]
? github.com/pion/turn/v2/examples/turn-client/udp [no test files]
? github.com/pion/turn/v2/examples/turn-server/add-software-attribute
[no test files]
? github.com/pion/turn/v2/examples/turn-server/log [no test files]
? github.com/pion/turn/v2/examples/turn-server/lt-cred [no test files]
? github.com/pion/turn/v2/examples/turn-server/port-range [no test files]
? github.com/pion/turn/v2/examples/turn-server/simple [no test files]
? github.com/pion/turn/v2/examples/turn-server/tcp [no test files]
? github.com/pion/turn/v2/examples/turn-server/tls [no test files]
Code in question: https://github.com/pion/turn/blob/master/client_test.go#L47
Cheers,
Sven
