Bug#1017746: assimp: CMake variable DRACO_LIBRARIES is deprecated

[Timo Röhling]

* IOhannes m zmölnig <umlae...@debian.org> [2022-08-21 11:01]:

I'm not an expert when it comes to Cmake (being an autotools guy), so patches 
welcome 😉

Sure, happy to help!
You could just replace "${DRACO_LIBRARIES}" with the literal
"draco::draco" target name, but in the attached patch, I added a check
to set the DRACO_LIBRARIES to draco::draco instead. This way, assimp
will build with both the bookworm and the bullseye version of draco.


Cheers
Timo

--
⢀⣴⠾⠻⢶⣦⠀   ╭────────────────────────────────────────────────────╮
⣾⠁⢠⠒⠀⣿⡁   │ Timo Röhling                                       │
⢿⡄⠘⠷⠚⠋⠀   │ 9B03 EBB9 8300 DF97 C2B1  23BF CC8C 6BDD 1403 F4CA │
⠈⠳⣄⠀⠀⠀⠀   ╰────────────────────────────────────────────────────╯

diff --git a/debian/patches/use-system-libdraco.patch b/debian/patches/use-system-libdraco.patch
index 76c1bcb..0946461 100644
--- a/debian/patches/use-system-libdraco.patch
+++ b/debian/patches/use-system-libdraco.patch
@@ -12,6 +12,9 @@ This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
  ENDIF()
  
 +find_package(draco CONFIG REQUIRED)
++if(NOT DRACO_LIBRARIES)
++    set(DRACO_LIBRARIES "draco::draco")
++endif()
 +target_link_libraries(assimp ${DRACO_LIBRARIES})
 +
  if(ASSIMP_ANDROID_JNIIOSYSTEM)

signature.asc
Description: PGP signature