Hello,

On Wed 24 Aug 2022 at 10:57PM +01, Ian Jackson wrote:

>
> Sean Whitton writes ("Bug#1017725: dgit-maint-native(7) examples should use 
> push-source (rather than push)"):
>> On Fri 19 Aug 2022 at 05:12PM +02, Philip Hands wrote:
>> > It strikes me that examples that currently show the `push` sub-command:
>> >
>> >   dgit -wgf --overwrite push
>> > and
>> >   dgit -wgf push
>> >
>> > should show the use of the `push-source` sub-command instead,
>> > since doing binary uploads to Debian now prevents migration to
>> > testing, so chances are that's not what most people want to do.
>>
>> Yes, that should be updated.
>>
>> > One could perhaps also add a `--with-binary` option for `push` and
>> > gently transition to defaulting to doing source-only uploads unless
>> > one specified that option via config or options.
>>
>> This is an intriguing suggestion, thank you.
>
> Given the differences between the behaviour of (what is now) push and
> of push-source, I'm not really convinced that a mere option is
> sufficient.
>
> But, how about this:
>
>  * Provide `push-built` which does what `push` does now.
>  * Change `push` to look at a (not distro-dependent) config option.
>     - for bookworm, defaults to "do push-built, warn"
>     - for bookworm+1, defaults to "do push-source"
>
> People who have scripts that do "dgit push" and need to work on older
> releases can safely pass the config option right away since unknown
> config options are ignored.

Yes, having a 'push-built' like this alongside 'push-source' sounds
better than the current push and push-source combination.  LGTM.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply via email to