Hi Balázs,
thanks for your patch. But this is unfortunately not correct:

On Tue, May 09, 2006 at 01:21:48AM +0200, Balázs Hámorszky wrote:

> i'we made a litle patch to /etc/init.d/smartmontools
> with it sata works well. i think.
> 
> enable_smart() {
>   echo -n "Enabling S.M.A.R.T. for:"
>   for device in $enable_smart; do
>         echo -n " $device"
>       if [ $device = /dev/sd[a-z] ]; then
>           $SMARTCTL --quietmode=errorsonly -d ata --smart=on $device || \
>               { echo -n "(failed)"; RET=2; }
not all sd? devices are sata, they could be regular scsi disks, in this
case we can't pass "-d ata". There are two possibilites here: use e.g.
"sdparm -i" to make sure it's a sata device or generalize "enable_smart"
to also carry information about the disk.

I currently even favour dropping enable_smart altogether since it's
rarely used (most people run smartd anyway and so don't need it at all)
and it causes problems when used with smartd. What do you think?
Cheers,
 -- Guido

>       else
>           $SMARTCTL --quietmode=errorsonly --smart=on $device || \
>               { echo -n "(failed)"; RET=2; }
>       fi
>   done
>   echo "."
> }
> 
> 
> -- Package-specific info:
> Ouput of /usr/share/bug/smartmontools:
> CONFIG_IDE_TASK_IOCTL=y
> 
> -- System Information:
> Debian Release: testing/unstable
>   APT prefers unstable
>   APT policy: (500, 'unstable')
> Architecture: i386 (i686)
> Shell:  /bin/sh linked to /bin/bash
> Kernel: Linux 2.6.16.14
> Locale: LANG=hu_HU, LC_CTYPE=hu_HU (charmap=ISO-8859-2)
> 
> Versions of packages smartmontools depends on:
> ii  debianutils                   2.16       Miscellaneous utilities specific 
> t
> ii  libc6                         2.3.6-7    GNU C Library: Shared libraries
> 
> Versions of packages smartmontools recommends:
> ii  mailx            1:8.1.2-0.20050715cvs-1 A simple mail user agent
> 
> -- debconf-show failed
> 

Reply via email to