Hi,

may I suggest to apply the following changes?

$ diff -u /usr/libexec/unbound-helper.ori /usr/libexec/unbound-helper
--- /usr/libexec/unbound-helper.ori     2022-10-04 17:25:48.531922943 +0200
+++ /usr/libexec/unbound-helper 2022-10-04 17:26:58.143255583 +0200
@@ -24,7 +24,7 @@
 fi

 do_resolvconf_start() {
-    [ false != "$RESOLVCONF" -a -x /sbin/resolvconf ] || return
+    [ false != "$RESOLVCONF" -a -x /sbin/resolvconf ] || return 0

     unbound-checkconf $CHROOT_DIR/$UNBOUND_CONF -o interface | {
         default=yes
@@ -44,13 +44,13 @@
 }

 do_resolvconf_stop() {
-    [ false != "$RESOLVCONF" -a -x /sbin/resolvconf ] || return
+    [ false != "$RESOLVCONF" -a -x /sbin/resolvconf ] || return 0

     /sbin/resolvconf -d lo.unbound
 }

 do_chroot_setup() {
-    [ -n "$CHROOT_DIR" -a -d "$CHROOT_DIR" ] || return
+    [ -n "$CHROOT_DIR" -a -d "$CHROOT_DIR" ] || return 0
     if [ "$CHROOT_DIR" != "$UNBOUND_BASE_DIR" ]; then
         # we probably should not do the force-recreate but just a refresh
         rm -rf   "$CHROOT_DIR/$UNBOUND_BASE_DIR"
@@ -79,7 +79,7 @@
 do_root_trust_anchor_update() {
     [ false != "$ROOT_TRUST_ANCHOR_UPDATE" -a \
       -n "$ROOT_TRUST_ANCHOR_FILE"  -a \
-      -r "$DNS_ROOT_KEY_FILE" ] || return
+      -r "$DNS_ROOT_KEY_FILE" ] || return 0

     if [ ! -e "$ROOT_TRUST_ANCHOR_FILE" ] ||
        # we do not want to copy if unbound's file is more recent

Without a return value, return would return the result of the previous if clause which is set to FALSE when the feature or condition isn't met.

Thanks!


--
Regards,
Thomas

Reply via email to