On Sat, 15 Oct 2022 14:28:12 +0200 Michael Biebl <bi...@debian.org> wrote:
Am 15.10.22 um 14:01 schrieb Helmut Grohne:
> Source: systemd
> Version: 251.6-1
> Severity: important
> Justification: breaks architecture bootstrap
> Tags: ftbfs patch
> User: helm...@debian.org
> Usertags: rebootstrap
>
> Hi,
>
> the addition of cryptsetup plugins broke the stage1 build. Do you think
> it would be possible to add a native stage1 build pass to salsa-ci such
> that you'd notice earlier? Of course you'd only get the failure then,
> not the patch. ;)
>
> What happens to break is missing files in dh_install. Clearly, the
> intention was not to include cryptsetup plugins in stage1 and I agree
> with that. Unfortunately, dh_install itself does not allow
> conditionalizing lines in .install files. I'm attaching a patch that
> uses dh-exec to achieve this and hope you like it. If not, maybe we can
> install the plugins from debian rules manually?
Given that dh-exec is basically unmaintained, I'm a bit reluctant to
switch to it.
The dh-exec package has a maintainer again. (I think this was mentioned
on IRC as well - repeating here for completeness)
Could you raise this with Niels/debhelper: I do think we need better
support for build profiles in dh_install.
Personally, I think dh-exec does a great job at providing filters (among
other features) to debhelper configuration files and I am not currently
not considering to absorbing them into debhelper itself.
Thanks,
~Niels