Package: signing-party
Version: 0.4.6-1
Severity: normal

It seems caff has a problem with non-ASCII characters:
When I set $CONFIG{'owner'} in ~/.caffrc to e.g. 'Johannes Weißl',
I get the following error from debian.org addresses:

Diagnostic-Code: X-Postfix; host master.debian.org[146.82.138.7] said: 550
    improper use of 8-bit data in message header (in reply to end of DATA 
    command)

And in messages from other caff-users the uid in the message body is
displayed as "Johannes Wei?\x9fl".

I wrote a patch that addresses the header-problem:
It encodes the owner in quoted-printable (it's a hack, and I didn't read
through RFC 2047).

The other problem is maybe because the information is gained from the
output of gpg (locale problem?!).


perl-version: v5.8.7
`locale charmap`: UTF-8
`file ~/.caffrc`: UTF-8 Unicode English text


-- 
Johannes Weißl
--- caff.org    2006-05-09 23:27:24.000000000 +0200
+++ caff        2006-05-10 20:19:11.000000000 +0200
@@ -297,6 +297,7 @@
 use File::Temp qw{tempdir};
 use Text::Template;
 use MIME::Entity;
+use Encode;
 use Fcntl;
 use IO::Select;
 use Getopt::Long;
@@ -335,6 +336,14 @@
 };
 
 
+sub encode_qp($) {
+    my @words;
+    foreach (split(/ /, shift)) {
+        push(@words, Encode::encode('MIME-Q', $_));
+    }
+    return join(" ", @words);
+};
+
 sub generate_config() {
        notice("Error: \$LOGNAME is not set.\n") unless defined $ENV{'LOGNAME'};
        my $gecos = defined $ENV{'LOGNAME'} ? (getpwnam($ENV{LOGNAME}))[6] : 
undef;
@@ -799,7 +808,7 @@
 
        $message_entity->head->add("Subject", "Your signed PGP key 0x$key_id");
        $message_entity->head->add("To", $address);
-       $message_entity->head->add("From", '"'.$CONFIG{'owner'}.'" 
<'.$CONFIG{'email'}.'>');
+       $message_entity->head->add("From", '"'.encode_qp($CONFIG{'owner'}).'" 
<'.$CONFIG{'email'}.'>');
        $message_entity->head->add("Reply-To", $CONFIG{'reply-to'}) if defined 
$CONFIG{'reply-to'};
        $message_entity->head->add("Bcc", $CONFIG{'bcc'}) if defined 
$CONFIG{'bcc'};
        $message_entity->head->add("User-Agent", $USER_AGENT);

Attachment: pgpa8U5BFV8kG.pgp
Description: PGP signature

Reply via email to