Hi! I've forwarded this upstream now.
On Tue, 2022-11-08 at 14:44:25 +0100, Guillem Jover wrote: > On Tue, 2022-11-08 at 16:32:25 +0300, Michael Tokarev wrote: > > On Tue, 08 Nov 2022 15:51:17 +0300 Michael Tokarev <m...@tls.msk.ru> wrote: > > > In liburing.h in 2.3, structures io_uring_cq and io_uring_sq changed > > > their sizes. Both of these structures are parts of io_uring structure > > > which the main part of the API. Here's the difference: > > > > > > @@ -43,7 +79,9 @@ > > > @@ -56,13 +94,18 @@ > > > size_t ring_sz; > > > void *ring_ptr; > > > - unsigned pad[4]; > > > + unsigned ring_mask; > > > + unsigned ring_entries; > > > + > > > + unsigned pad[2]; > > > > This does not look like it is changing the size actually, - I haven't > > noticed it adjusts pad[] accordingly. So this is not the issue here. > > > > But the end result is the same: samba compiled with liburing 2.2 does > > not work with runtime liburing 2.3, and samba compiled with liburing > > 2.3 does not work with runtime liburing 2.2. I've checked the code and this is weird, the new code is taking care of initializing all members with the new shared library. So I'd expect samba built against the old liburing to work with the new one. But the problem seems to be that code built against the new liburing will not work with the old liburing, as that one does not initialize the new members being used from the inline functions. If you are really seeing samba linked against old liburing not working with the new liburing, then we'd need to dig further to see what else might be missing, but I'm currently not seeing it just by a very quick code staring. Thanks, Guillem
