Hi,

Same opinion on my side: it could be removed.
Concerning the proposal to upgrade to version 0.24 (see #1024098), it's the same
thing since the source code of celluloid doesn't correspond so much anymore:

$ rgrep "youtube" celluloid-0.24
celluloid-0.24/flatpak/io.github.celluloid_player.Celluloid.json:          
"name": "youtube-dl",
celluloid-0.24/flatpak/io.github.celluloid_player.Celluloid.json:          
"make-args": ["youtube-dl", "PYTHON=/usr/bin/python3"],
celluloid-0.24/flatpak/io.github.celluloid_player.Celluloid.json:          
"post-install": ["install youtube-dl /app/bin"],
celluloid-0.24/flatpak/io.github.celluloid_player.Celluloid.json:            
"url": "https://github.com/rg3/youtube-dl.git";,
celluloid-0.24/README.md:- youtube-dl (optional)

I don't think that this flatpak json file has any effect on the debian package 
content.

Thanks,
Patrice

On Wed, 16 Nov 2022 02:03:06 -0500 Andres Salomon <dilin...@queued.net> wrote:
> Package: celluloid
> Version: 0.20-2
> Severity: normal
> 
> We are planning for the youtube-dl package to become an empty package 
> that simply depends on yt-dlp (see https://bugs.debian.org/994151 ). 
> Your package has a "Recommends: youtube-dl". However, in looking 
> through the source code, I don't see anything actually calling out to 
> youtube-dl directly. I suspect that (since this package is a frontend 
> for mpv) mpv is instead calling youtube-dl. Newer versions of mpv are 
> aware of, recommend, and will prefer to use yt-dlp.
> 
> Please test your package with yt-dlp and update the Recommends to 
> replace "youtube-dl" with "yt-dlp" once you've verified that it works 
> as intended.
> 
> Thanks,
> Andres
> 
> 
> 
> 

Reply via email to