Source: brewtarget
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: kernel
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The build date is embedded in /usr/bin/brewtarget:

  
https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/brewtarget.html

  Linux-5.10.0-19-amd64
  vs.
  Linux-5.19.0-0.deb11.2-amd64

The attached patch to src/main.cpp fixes this by removing
CMAKE_HOST_SYSTEM and CMAKE_SYSTEM, which includes the kernel version.

According to my local tests, With this patch applied brewtarget should
build reproducibly on tests.reproducible-builds.org!

Thanks for maintaining brewtarget!

live well,
  vagrant
From b3b4f7b8bc2b3f08f32a1d3ead764468c0bdf23a Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Fri, 18 Nov 2022 18:35:14 +0000
Subject: [PATCH] src/main.cpp: do not embed the value of CMAKE_HOST_SYSTEM or
 CMAKE_SYSTEM.

This embeds the version of the running kernel, breaking reproducible
builds.

https://tests.reproducible-builds.org/debian/issues/unstable/captures_kernel_version_via_CMAKE_SYSTEM_issue.html
---
 src/main.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main.cpp b/src/main.cpp
index 227d530..2cc767f 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -195,7 +195,7 @@ int main(int argc, char **argv) {
          "Starting" << CONFIG_APPLICATION_NAME_UC << "v" << CONFIG_VERSION_STRING << " (app name" <<
          app.applicationName() << ") on " << QSysInfo::prettyProductName();
       qInfo() <<
-         "Built at" << BUILD_TIMESTAMP << "on" << CMAKE_HOST_SYSTEM << "for" << CMAKE_SYSTEM << "with" <<
+         "Built at" << BUILD_TIMESTAMP <<
          CMAKE_CXX_COMPILER_ID << "compiler";
       qInfo() << "Log directory:" << Logging::getDirectory().absolutePath();
       qInfo() << "Using Qt runtime v" << qVersion() << " (compiled against Qt v" << QT_VERSION_STR << ")";
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature

Reply via email to