Control: forwarded -1 https://pagure.io/bind-dyndb-ldap/issue/216
On 27/12/22 06:16 PM, Bernhard Schmidt wrote: Hi, so this is really massively broken :-( > ../../src/log.h:21:9: error: too few arguments to function ‘isc_error_fatal’ > 21 | isc_error_fatal(__FILE__, __LINE__, __VA_ARGS__) > | ^~~~~~~~~~~~~~~ That one has been introduced in 9.18.9+. There is an open pull request upstream at https://pagure.io/bind-dyndb-ldap/pull-request/215 , which (together with bumping LIBDNS_VERSION_MAJOR in d/p/hardcode-version.diff) fixes the logging errors. > ../../src/ldap_driver.c: In function ‘allrdatasets’: > ../../src/ldap_driver.c:474:71: error: passing argument 5 of > ‘dns_db_allrdatasets’ makes integer from pointer without a cast > [-Werror=int-conversion] > 474 | return dns_db_allrdatasets(ldapdb->rbtdb, node, version, now, > iteratorp); > | > ^~~~~~~~~ > | > | > | > dns_rdatasetiter_t ** {aka struct dns_rdatasetiter **} Those appear to be new issues in 9.18.10. I have filed a new upstream bugreport at https://pagure.io/bind-dyndb-ldap/issue/216 . Both dns_db_allrdatasets and dns_zt_apply gained an additional argument https://gitlab.isc.org/isc-projects/bind9/-/commit/1de9c052107a6f24e565441f53e4d8b33bb2e30a https://gitlab.isc.org/isc-projects/bind9/-/commit/6f998bbe518ae629685404bcfddcfd6067176660 and while my attempts to monkeypatch the additional 0 argument into dns_db_allrdatasets cleared most of the warnings I'm lost with the remaining errors. Does not really help that I barely know C, my knowledge ends pretty much here and I have no idea how to go further. In file included from ../../src/zone_register.h:8, from ../../src/ldap_convert.c:28: /usr/include/dns/zt.h:171:28: error: unknown type name ‘isc_rwlocktype_t’; did you mean ‘isc_rwlock_t’? 171 | dns_zt_apply(dns_zt_t *zt, isc_rwlocktype_t lock, bool stop, isc_result_t *sub, | ^~~~~~~~~~~~~~~~ | isc_rwlock_t libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../src -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Werror -std=gnu99 -O2 -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wno-uninitialized -fvisibility=hidden -fno-delete-null-pointer-checks -std=gnu11 -c ../../src/ldap_helper.c -fPIC -DPIC -o .libs/ldap_la-ldap_helper.o ../../src/ldap_driver.c:950:9: error: initialization of ‘isc_result_t (*)(dns_db_t *, dns_dbnode_t *, dns_dbversion_t *, unsigned int, isc_stdtime_t, dns_rdatasetiter_t **)’ {aka ‘enum isc_result (*)(struct dns_db *, void *, void *, unsigned int, unsigned int, struct dns_rdatasetiter **)’} from incompatible pointer type ‘isc_result_t (*)(dns_db_t *, dns_dbnode_t *, dns_dbversion_t *, isc_stdtime_t, dns_rdatasetiter_t **)’ {aka ‘enum isc_result (*)(struct dns_db *, void *, void *, unsigned int, struct dns_rdatasetiter **)’} [-Werror=incompatible-pointer-types] 950 | allrdatasets, | ^~~~~~~~~~~~ ../../src/ldap_driver.c:950:9: note: (near initialization for ‘ldapdb_methods.allrdatasets’)