Control: retitle -1 gnuplot-doc: spurious menu at the end of Section 4 of 
gnuplot.info breaks navigation in info
Control: notforwarded -1

The forward was for the missing terminal types. I have not reported
this second bug upstream yet.

On 2022-12-29 00:51:19 +0100, Vincent Lefevre wrote:
[...]
> This solves the inclusion of the terminal types, but unfortunately,
> the buggy menu is a separate problem. In the gnuplot.info.gz file
> with the patch:
> 
> [...]
> 4.1.54 xlib
> -----------
> The 'xlib' terminal driver supports the X11 Windows System.  It
> generates gnuplot_x11 commands, but sends them to the output file
> specified by 'set output '<filename>''.  'set term x11' is equivalent to
> 'set output "|gnuplot_x11 -noevents"; set term xlib'.  'xlib' takes the
> same set of options as 'x11'."
> * Menu:
> * Bugs::
> File: gnuplot.info,  Node: Bugs,  Next: Concept_Index,  Prev: Terminal_types, 
>  Up: Top
> 5 Bugs
> ******
> [...]
> 
> i.e. the menu is still there, so that going backward from Section 5
> goes to Section 5.2 instead of 4.1.54.

I've attached a patch for this issue: this incorrect menu is added
by 3 lines in doc2texi.el, with the comment

  ; `texinfo-all-menus-update' seems
  ; to miss this one.  how odd.

Perhaps this was added as a workaround to an old bug. With my
patch that removes these 3 lines, the navigation is now correct
(going backward from Section 5 "Bugs" sends to the end of
Section 4 as expected), and I cannot see any new issue.

-- 
Vincent Lefèvre <vinc...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Description: Do not generate a spurious menu in gnuplot.info.
  A spurious menu with a "Bugs" menu item is generated at the end
  of Section 4 (just before Section 5 "Bugs"). This is incorrect
  and breaks navigation in "info": going backward from Section 5
  sends to Section 5.2 instead of 4.1.54.
Bug-Debian: https://bugs.debian.org/989029
Author: Vincent Lefevre <vinc...@vinc17.net>
Last-Update: 2022-12-29

Index: gnuplot-5.4.4+dfsg1/docs/doc2texi.el
===================================================================
--- gnuplot-5.4.4+dfsg1.orig/docs/doc2texi.el
+++ gnuplot-5.4.4+dfsg1/docs/doc2texi.el
@@ -415,9 +415,6 @@ particular conversion chore."
     (search-forward "@node")
     ;; (beginning-of-line)
     ;; (insert "\n\n" d2t-main-menu "\n\n")
-    (search-forward "@node Bugs")	; `texinfo-all-menus-update' seems
-    (beginning-of-line)			; to miss this one.  how odd.
-    (insert "@menu\n* Bugs::\t\t\t\n@end menu\n\n")
     (goto-char (point-max))
     (insert d2t-texi-footer))
   (load-library "texinfo") ;; now do the hard stuff with texinfo-mode

Reply via email to