On Fri, Apr 28, 2006 at 02:02:47PM +0200, Jonas Meurer wrote:
On 22/04/2006 Andres Salomon wrote:
Attached is a patch that fixes this issue.  In the process, it also gets
rid of getpass() (which is considered obsolete, and should not be used;
see the manpage).  Instead, we use select()+read(), along w/ manually
disabling ECHO in the terminal.
...
i've tested your patch, and it seems to work perfectly well.
but unfortunately this is only the case for the luks* features of
cryptsetup. Plain 'cryptsetup create' still leaves the terminal in a bad
state after terminating the passphrase prompt.

I can't reproduce this. Both luks and non-luks seem to leave the terminal in a state which is fine. Looking at the code in lib/setup.c, both luks and non-luks use the same function (get-key) so if one works, both should work.

Regards,
David


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to