tags 1019526 patch
thanks
Looks like the issue has been addressed upstream
https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1640 with
2893f8e3f9cc94f969a7f2062585aef4161df235 which I'm guessing should
show up when 44 is released.
That said, the patch applies cleanly to 43, so this could be pulled
forward early to address the segfault. Patch attached.
From 2893f8e3f9cc94f969a7f2062585aef4161df235 Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq <sa...@sadiqpk.org>
Date: Tue, 15 Nov 2022 16:01:43 +0530
Subject: [PATCH] color: Select first device row only if non-NULL
Otherwise we might read some invalid memory resulting in a crash
---
panels/color/cc-color-panel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/panels/color/cc-color-panel.c b/panels/color/cc-color-panel.c
index f55fcf93b..42820c798 100644
--- a/panels/color/cc-color-panel.c
+++ b/panels/color/cc-color-panel.c
@@ -1642,7 +1642,8 @@ gcm_prefs_update_device_list_extra_entry (CcColorPanel *prefs)
gtk_widget_set_visible (prefs->box_devices, first_row != NULL);
/* if we have only one device expand it by default */
- if (gtk_list_box_get_row_at_index (prefs->list_box, 1) == NULL)
+ if (first_row != NULL &&
+ gtk_list_box_get_row_at_index (prefs->list_box, 1) == NULL)
cc_color_device_set_expanded (CC_COLOR_DEVICE (first_row), TRUE);
}
--
2.39.0.314.g84b9a713c41-goog
