reopen 1021551
retitle 1021551 voms-api-java: FTBFS in bullseye because of expired
certificates in test suite
found 1021551 3.3.2-1
found 1021551 3.3.2-3
fixed 1021551 3.3.2-4
tags 1021551 + ftbfs
thanks
Hi. I'm reopening because this problem also happens in bullseye,
and packages in stable must build in stable.
I attach an upload proposal to fix this in bullseye, which
is essentially all the things that have been disabled
since version 3.3.2-1 folded into a new 3.3.2-1+deb11u1 version
for stable.
Maybe the item about "Disable tests failing with bouncycastle 1.71"
is not strictly necessary for bullseye, so I'm doubt about that one.
(I tried not to include such item, but it was not completely trivial
because of the interspersed comments in debian/patches/series).
The procedure for a stable upload, if you have not done it before,
is explained here:
https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#special-case-uploads-to-the-stable-and-oldstable-distributions
Thanks.
diff --git a/debian/changelog b/debian/changelog
index b928b66..80f45cd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+voms-api-java (3.3.2-1+deb11u1) bullseye; urgency=medium
+
+ * Disable tests failing with bouncycastle 1.71 (Closes: #1011698)
+ * Disable failing multi-thread test
+ * Disable tests using obsolete hashes (md5/sha1)
+ * Disable tests that fail due to expired certificates (Closes: #1021551)
+ * Disable tests that fail due to more expired certificates
+
+ -- Mattias Ellert <mattias.ell...@physics.uu.se> Sat, 31 Dec 2022 19:58:00
+0100
+
voms-api-java (3.3.2-1) unstable; urgency=medium
* Update to version 3.3.2 - matches canl-java 2.6.x
diff --git a/debian/copyright b/debian/copyright
index 947c592..5be590f 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -19,7 +19,7 @@ License: Apache-2.0
Files: debian/*
Copyright:
- 2012-2020, Mattias Ellert <mattias.ell...@physics.uu.se>
+ 2012-2022, Mattias Ellert <mattias.ell...@physics.uu.se>
License: Apache-2.0
License: Apache-2.0
diff --git a/debian/patches/series b/debian/patches/series
index 1fd6782..0675e82 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,13 @@
-# Disable tests using non-local network interface
-voms-api-java-no-local.patch
+# Disable failing tests
+# IllegalState object explicit - implicit expected.
+# https://github.com/italiangrid/voms-api-java/issues/29
+voms-api-java-disable-some-tests.patch
+
+# Disable tests that fail due to expired certificates
+# https://github.com/italiangrid/voms-api-java/issues/30
+# 2022-09-24 (test0.cert.pem, wilco_cnaf_infn_it.cert.pem)
+voms-api-java-expired-2022-09-24.patch
+# 2022-10-08 (test_host_cnaf_infn_it.cert.pem)
+voms-api-java-expired-2022-10-08.patch
+# 2022-12-02 (test_host_2_cnaf_infn_it.cert.pem)
+voms-api-java-expired-2022-12-12.patch
diff --git a/debian/patches/voms-api-java-disable-some-tests.patch
b/debian/patches/voms-api-java-disable-some-tests.patch
new file mode 100644
index 0000000..5f2cc99
--- /dev/null
+++ b/debian/patches/voms-api-java-disable-some-tests.patch
@@ -0,0 +1,62 @@
+diff --git a/src/test/java/org/italiangrid/voms/test/ac/TestACGeneration.java
b/src/test/java/org/italiangrid/voms/test/ac/TestACGeneration.java
+index bc7557c..32ba7a5 100644
+--- a/src/test/java/org/italiangrid/voms/test/ac/TestACGeneration.java
++++ b/src/test/java/org/italiangrid/voms/test/ac/TestACGeneration.java
+@@ -191,7 +191,7 @@ public class TestACGeneration {
+ return ga;
+ }
+
+- @Test
++ // @Test
+ public void testGeneratedACParsing() throws KeyStoreException,
+ CertificateException, FileNotFoundException, IOException,
+ OperatorCreationException {
+@@ -230,7 +230,7 @@ public class TestACGeneration {
+
+ }
+
+- @Test
++ // @Test
+ public void testACValidation() {
+
+ ValidationResultChecker c = new ValidationResultChecker(true);
+@@ -247,7 +247,7 @@ public class TestACGeneration {
+
+ }
+
+- @Test
++ // @Test
+ public void testLSCValidationFailure() {
+
+ ValidationResultChecker c = new ValidationResultChecker(false,
+@@ -264,7 +264,7 @@ public class TestACGeneration {
+ assertEquals(validatedAttrs.size(), 0);
+ }
+
+- @Test
++ // @Test
+ public void testExpiredAACertValidationFailure()
+ throws OperatorCreationException {
+
+@@ -284,7 +284,7 @@ public class TestACGeneration {
+ assertEquals(validatedAttrs.size(), 0);
+ }
+
+- @Test
++ // @Test
+ public void testRevokedAACertValidationFailure() {
+
+ ValidationResultChecker c = new ValidationResultChecker(false,
+diff --git
a/src/test/java/org/italiangrid/voms/test/ac/TestFakeVOMSACService.java
b/src/test/java/org/italiangrid/voms/test/ac/TestFakeVOMSACService.java
+index 6eca55f..49f0498 100644
+--- a/src/test/java/org/italiangrid/voms/test/ac/TestFakeVOMSACService.java
++++ b/src/test/java/org/italiangrid/voms/test/ac/TestFakeVOMSACService.java
+@@ -54,7 +54,7 @@ public class TestFakeVOMSACService extends TestACSupport {
+ initializeCredentials();
+ }
+
+- @Test
++ // @Test
+ public void testFakeAcServiceCreation() {
+
+ ACGenerationParams params = ACGenerationParams.builder()
diff --git a/debian/patches/voms-api-java-expired-2022-09-24.patch
b/debian/patches/voms-api-java-expired-2022-09-24.patch
new file mode 100644
index 0000000..7169433
--- /dev/null
+++ b/debian/patches/voms-api-java-expired-2022-09-24.patch
@@ -0,0 +1,48 @@
+diff --git
a/src/test/java/org/italiangrid/voms/test/TestOpensslHashFunction.java
b/src/test/java/org/italiangrid/voms/test/TestOpensslHashFunction.java
+index 6f57833..aa800ac 100644
+--- a/src/test/java/org/italiangrid/voms/test/TestOpensslHashFunction.java
++++ b/src/test/java/org/italiangrid/voms/test/TestOpensslHashFunction.java
+@@ -47,7 +47,7 @@ public class TestOpensslHashFunction {
+ cred = new PEMCredential(userKey, userCert, keyPassword.toCharArray());
+ }
+
+- @Test
++ // @Test
+ public void testDefaultHashIsMD5() {
+
+ CertificateValidatorBuilder builder = new CertificateValidatorBuilder();
+@@ -60,7 +60,7 @@ public class TestOpensslHashFunction {
+
+ }
+
+- @Test
++ // @Test
+ public void testSHA1Hash() {
+
+ CertificateValidatorBuilder builder = new CertificateValidatorBuilder();
+diff --git a/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
b/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
+index 8b420a9..df91a02 100644
+--- a/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
++++ b/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
+@@ -227,7 +227,7 @@ public class TestACValidator implements Fixture {
+
+ }
+
+- @Test
++ // @Test
+ public void testInvalidLSCSignatureFailure() throws Exception {
+
+ VOMSAA aa = Utils.getVOMSAA();
+diff --git
a/src/test/java/org/italiangrid/voms/test/mt/TestConcurrentValidation.java
b/src/test/java/org/italiangrid/voms/test/mt/TestConcurrentValidation.java
+index 496455e..d9b26cc 100644
+--- a/src/test/java/org/italiangrid/voms/test/mt/TestConcurrentValidation.java
++++ b/src/test/java/org/italiangrid/voms/test/mt/TestConcurrentValidation.java
+@@ -167,7 +167,7 @@ public class TestConcurrentValidation {
+
+ }
+
+- @Test
++ // @Test
+ public void test() throws InterruptedException, BrokenBarrierException {
+
+ long start = System.currentTimeMillis();
diff --git a/debian/patches/voms-api-java-expired-2022-10-08.patch
b/debian/patches/voms-api-java-expired-2022-10-08.patch
new file mode 100644
index 0000000..24839bb
--- /dev/null
+++ b/debian/patches/voms-api-java-expired-2022-10-08.patch
@@ -0,0 +1,111 @@
+diff --git a/src/test/java/org/italiangrid/voms/test/ac/TestACGeneration.java
b/src/test/java/org/italiangrid/voms/test/ac/TestACGeneration.java
+index bc7557c..80120db 100644
+--- a/src/test/java/org/italiangrid/voms/test/ac/TestACGeneration.java
++++ b/src/test/java/org/italiangrid/voms/test/ac/TestACGeneration.java
+@@ -301,7 +301,7 @@ public class TestACGeneration {
+ assertEquals(validatedAttrs.size(), 0);
+ }
+
+- @Test
++ // @Test
+ public void testSuccesfullACExtractionFromProxy() {
+
+ ValidationResultChecker c = new ValidationResultChecker(true);
+diff --git a/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
b/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
+index 8b420a9..b35aa8a 100644
+--- a/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
++++ b/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
+@@ -62,7 +62,7 @@ public class TestACValidator implements Fixture {
+
+ }
+
+- @Test
++ // @Test
+ public void testValidityCheckSuccess() throws Exception {
+
+ ProxyCertificate proxy = Utils.getVOMSAA().createVOMSProxy(holder,
defaultVOFqans);
+@@ -96,7 +96,7 @@ public class TestACValidator implements Fixture {
+ Assert.assertEquals(VOMSValidationErrorCode.acNotValidAtCurrentTime,
m.getErrorCode());
+ }
+
+- @Test
++ // @Test
+ public void testHolderCheckFailure() throws Exception {
+
+ ProxyCertificate proxy =
+@@ -172,7 +172,7 @@ public class TestACValidator implements Fixture {
+
+ }
+
+- @Test
++ // @Test
+ public void testEmptyACCertsExtensionSuccess() throws Exception {
+
+ VOMSAA aa = Utils.getVOMSAA();
+@@ -256,7 +256,7 @@ public class TestACValidator implements Fixture {
+ r.getValidationErrors().get(1).getErrorCode());
+ }
+
+- @Test
++ // @Test
+ public void testUnknownCriticalExtensionFailure() throws Exception {
+
+ VOMSAA aa = Utils.getVOMSAA();
+@@ -281,7 +281,7 @@ public class TestACValidator implements Fixture {
+ r.getValidationErrors().get(0).getMessage());
+ }
+
+- @Test
++ // @Test
+ public void testCriticalAKIDFailure() throws Exception {
+
+ VOMSAA aa = Utils.getVOMSAA();
+@@ -304,7 +304,7 @@ public class TestACValidator implements Fixture {
+ r.getValidationErrors().get(0).getMessage());
+ }
+
+- @Test
++ // @Test
+ public void testCriticalNoRevAvailFailure() throws Exception {
+
+ VOMSAA aa = Utils.getVOMSAA();
+@@ -329,7 +329,7 @@ public class TestACValidator implements Fixture {
+ r.getValidationErrors().get(0).getMessage());
+ }
+
+- @Test
++ // @Test
+ public void testTargetValidationSuccess() throws Exception {
+
+ VOMSAA aa = Utils.getVOMSAA();
+@@ -355,7 +355,7 @@ public class TestACValidator implements Fixture {
+ Assert.assertTrue(r.isValid());
+ }
+
+- @Test
++ // @Test
+ public void testTargetValidationFailure() throws Exception {
+
+ VOMSAA aa = Utils.getVOMSAA();
+@@ -375,7 +375,7 @@ public class TestACValidator implements Fixture {
+
+ }
+
+- @Test
++ // @Test
+ public void testResolveHostnameException() throws Exception {
+
+ VOMSAA aa = Utils.getVOMSAA();
+diff --git a/src/test/java/org/italiangrid/voms/test/req/TestRequests.java
b/src/test/java/org/italiangrid/voms/test/req/TestRequests.java
+index d00ad46..214bde7 100644
+--- a/src/test/java/org/italiangrid/voms/test/req/TestRequests.java
++++ b/src/test/java/org/italiangrid/voms/test/req/TestRequests.java
+@@ -41,7 +41,7 @@ import eu.emi.security.authn.x509.impl.PEMCredential;
+
+ public class TestRequests implements Fixture {
+
+- @Test
++ // @Test
+ public void testEchoRequest() throws Exception {
+
+ VOMSACService acService = Utils.buildACService(new
EchoVOMSProtocol(Utils.getAACredential()));
diff --git a/debian/patches/voms-api-java-expired-2022-12-12.patch
b/debian/patches/voms-api-java-expired-2022-12-12.patch
new file mode 100644
index 0000000..7e13740
--- /dev/null
+++ b/debian/patches/voms-api-java-expired-2022-12-12.patch
@@ -0,0 +1,13 @@
+diff --git a/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
b/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
+index 8b420a9..ef0b14a 100644
+--- a/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
++++ b/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
+@@ -111,7 +111,7 @@ public class TestACValidator implements Fixture {
+ Assert.assertEquals(VOMSValidationErrorCode.acHolderDoesntMatchCertChain,
m.getErrorCode());
+ }
+
+- @Test
++ // @Test
+ public void testSignatureCheckFailure() throws Exception {
+
+ ProxyCertificate proxy = Utils.getVOMSAA().createVOMSProxy(holder,
defaultVOFqans);
diff --git a/debian/patches/voms-api-java-no-local.patch
b/debian/patches/voms-api-java-no-local.patch
deleted file mode 100644
index 42542e1..0000000
--- a/debian/patches/voms-api-java-no-local.patch
+++ /dev/null
@@ -1,21 +0,0 @@
-diff -ur
voms-api-java-3.3.2.orig/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
voms-api-java-3.3.2/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
----
voms-api-java-3.3.2.orig/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
2020-10-08 17:57:55.000000000 +0200
-+++
voms-api-java-3.3.2/src/test/java/org/italiangrid/voms/test/ac/TestACValidator.java
2020-10-14 07:49:04.716000000 +0200
-@@ -329,7 +329,7 @@
- r.getValidationErrors().get(0).getMessage());
- }
-
-- @Test
-+ // @Test
- public void testTargetValidationSuccess() throws Exception {
-
- VOMSAA aa = Utils.getVOMSAA();
-@@ -355,7 +355,7 @@
- Assert.assertTrue(r.isValid());
- }
-
-- @Test
-+ // @Test
- public void testTargetValidationFailure() throws Exception {
-
- VOMSAA aa = Utils.getVOMSAA();
