On Tue, 10 Jan 2023 06:40:08 +0100 Matthias Klose <d...@ubuntu.com> wrote: > Version: 10.1.0-1 > > Fixed. > >
As this happens with version 10.2.1-6 I'm confused about how 10.1.0-1 could contain the fix? FWIW, even though this is a GCC bug I bisected it in the Linux kernel with good=6.1.0 and bad=6.1.2 and found the following commit as trigger for GCC 10.2. Reverting it fixes compilation here on GCC 10.2.1-6 commit ed88147bfb4e7cd009cb33c7395a45d52f296bcc Author: Kees Cook <keesc...@chromium.org> Date: Tue Oct 25 16:05:18 2022 -0700 fortify: Do not cast to "unsigned char" [ Upstream commit e9a40e1585d792751d3a122392695e5a53032809 ] Do not cast to "unsigned char", as this needlessly creates type problems when attempting builds without -Wno-pointer-sign[1]. The intent of the cast is to drop possible "const" types. [1] https://lore.kernel.org/lkml/CAHk-=wgz3uba8w7kdxhsqr1qvfemyl+ofqdefjnkeqxg8qz...@mail.gmail.com/ Suggested-by: Linus Torvalds <torva...@linux-foundation.org> Fixes: 3009f891bb9f ("fortify: Allow strlen() and strnlen() to pass compile-time known lengths") Cc: linux-harden...@vger.kernel.org Signed-off-by: Kees Cook <keesc...@chromium.org> Signed-off-by: Sasha Levin <sas...@kernel.org> diff --git a/include/linux/fortify-string.h b/include/linux/fortify-string.h index 1067a8450826..5001a11258e4 100644 --- a/include/linux/fortify-string.h +++ b/include/linux/fortify-string.h @@ -18,7 +18,7 @@ void __write_overflow_field(size_t avail, size_t wanted) __compiletime_warning(" #define __compiletime_strlen(p) \ ({ \ - unsigned char *__p = (unsigned char *)(p); \ + char *__p = (char *)(p); \ size_t __ret = SIZE_MAX; \ size_t __p_size = __member_size(p); \ if (__p_size != SIZE_MAX && \