Hello Lucas Nussbaum, Could you please provide some additional input? See below.
On Sun, Jan 01, 2023 at 03:33:44PM +0100, Lucas Nussbaum wrote: > Source: gh > Version: 2.18.1+dfsg1-1 > Severity: serious > Justification: FTBFS [...] > > === RUN TestStartJupyterServerFailure > > client_test.go:70: error connecting to internal server: failed to share > > remote port 16634: dial tcp 127.0.0.1:50051: connect: connection refused > > --- FAIL: TestStartJupyterServerFailure (0.00s) > > FAIL > > FAIL github.com/cli/cli/v2/internal/codespaces/grpc 0.039s > > ? github.com/cli/cli/v2/internal/codespaces/grpc/jupyter [no > > test files] > > ? github.com/cli/cli/v2/internal/codespaces/grpc/test [no > > test files] > > ? github.com/cli/cli/v2/internal/config [no test files] [...] Port 16634 is hardcoded at: ./internal/codespaces/grpc/client.go: codespacesInternalPort = 16634 If this port is not available I presume things will just fail. I've rebuilt the package locally and it succeeds for me. It also succeded on the official buildds. If you are able to reproduce the problem it would be great if you could check what is using the port to identify if it's some external program using this port and thus making the test fail or if it possibly is the test-suite racing against itself somehow. As far as I can tell right now, this issue doesn't seem release-critical to me so consider if maybe the severity should be downgraded. Regards, Andreas Henriksson
