Source: kitty
Version: 0.26.5-2
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu lunar

Hi James,

Since version 0.26.5, kitty has been failing to build from source on Ubuntu
with test failures, even though it builds fine on Debian:

[...]
======================================================================
ERROR: test_ssh_shell_integration (kitty_tests.ssh.SSHKitten)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/kitty/launcher/../../kitty_tests/ssh.py", line 239, in 
test_ssh_shell_integration
    pty.wait_till(lambda: 'kitty=fruity' in pty.screen_contents())
    login_shell = 'bash'
    num_lines = 2
    ok_login_shell = 'bash'
    pty = <kitty_tests.PTY object at 0x7fd0c5712620>
    self = <kitty_tests.ssh.SSHKitten testMethod=test_ssh_shell_integration>
    sh = 'dash'
    tdir = '/tmp/tmpct5s6c0x'
    val = ''
  File "/<<PKGBUILDDIR>>/kitty/launcher/../../kitty_tests/__init__.py", line 
297, in wait_till
    raise TimeoutError(f'The condition was not met. Screen contents: \n 
{repr(self.screen_contents())}')
    end_time = 1963.133780143
    q = <function SSHKitten.test_ssh_shell_integration.<locals>.<lambda> at 
0x7fd0c33475b0>
    self = <kitty_tests.PTY object at 0x7fd0c5712620>
TimeoutError: The condition was not met. Screen contents: 
 'UNTAR_DONE\nbuildd@lcy02-amd64-004:~$ echo 
"$TERM=fruity"\nunknown=fruity\nbuildd@lcy02-amd64-004:~$ '

[...]

  (https://launchpad.net/ubuntu/+source/kitty/0.26.5-2/+build/25419959)

It appears this works in Debian but not in Ubuntu because Debian's builders
have an empty $TERM in the build environment, whereas Ubuntu has it set by
default to 'unknown' (as shown above).  But if I build this in either a
Debian or Ubuntu chroot locally, the test fails because of a non-empty TERM
in the environment, causing this test to fail.

Since this only concerns the behavior of a test rather than a problem with
the package's code, it seems the appropriate fix is to set TERM= in the
environment when calling the tests.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org

Attachment: signature.asc
Description: PGP signature

Reply via email to