Hi,
On Wed, Feb 01, 2023 at 04:46:14PM +0100, Guido Günther wrote:
> Hi,
> On Wed, Feb 01, 2023 at 04:37:37PM +0100, Andreas Henriksson wrote:
> > On Wed, Feb 01, 2023 at 04:23:00PM +0100, Andreas Henriksson wrote:
> > > On Wed, Feb 01, 2023 at 04:03:47PM +0100, Guido Günther wrote:
> > > > Hi,
> > > > [..snip..]
> > > > > This seems to be caused by wlroots/experimental missing a
> > > > > build-dependency on libvulkan-dev and indeed after installing
> > > > > that package the build works again.
> > > > 
> > > > There is a build-dependency on libvulkan-dev. I think what you mean is
> > > > the lack of a dependency in the libwlroots-dev package?
> > > 
> > > Exactly... I've already retitled the bug report (again) to remove
> > > my incorrect use of build-dep, when what I mean was -dev package
> > > depending on another -dev package.
> > 
> > FWIW here are some examples of autopkgtest for checking if pkg-config
> > works for your own -dev packages:
> > https://sources.debian.org/src/util-linux/2.38.1-4/debian/tests/
> 
> We have tests for that like ages:
> 
>   
> https://salsa.debian.org/swaywm-team/wlroots/-/blob/debian/latest/debian/tests/
> 
> It just won't trigger if you don't need the vulkan renderer. Feel free
> to submit a patch that exercises that as well.

So I looked at the old logs and why the tests passed:
   
Package vulkan was not found in the pkg-config search path.
Perhaps you should add the directory containing `vulkan.pc'
to the PKG_CONFIG_PATH environment variable
Package 'vulkan', required by 'wlroots', not found
gcc  debian/tests/test.c -lwlroots  -lwayland-server
Build test of debian/tests/test.c succeeded

The tests succeeded as the --libs check correctly prints `-lwlroots`
*and* $(shell pkg-config …) in make doesn't fail on errors. Using a
shell script instead

   https://salsa.debian.org/swaywm-team/wlroots/-/merge_requests/19

will guard against that in the future.
Cheers,
 -- Guido

Reply via email to