Package: logtool
Severity: minor
Tags: patch

Hi,

I've seen that you have rewritten the debconf templates, but there is
still some parts that may be improved.


- Reply positively to manually write a database, or negatively to use the
+ Accept this option to manually write a database, and do not accept to use the
  database from the package "logcheck-database".

"positively" and "negatively" are still assumptions about interfaces.
Something like "Accept this option" is better for interfaces with
checkboxes.


-_Description: What do you want the ${level} level of regular expressions to do?
+_Description: Action to perform by the ${level} level of regular expressions:

This was still not a prompt. With this rephrasing, you can remove the
line
  logtool: malformed-prompt-in-templates logtool/map-level-to-file
from the logtool.lintian-overrides file, as this won't be too long.


-_Description: Please do not select an action more than once
+_Description: Action selected more than once

A sentence without a dot is still not a correct title, even if this is
harder to be detected by lintian.


Note that if you want to completly remove the logtool.lintian-overrides
file, you may also apply the following change (not included in the
patch):
  -Description: Ignored template
  +Description: Ignored template:
As this template is never displayed to the user, it doesn't change
anything.

Cheers,

-- 
Thomas Huriaux
--- templates.orig      2006-05-15 13:14:59.000000000 +0200
+++ templates   2006-05-15 13:18:46.000000000 +0200
@@ -12,7 +12,7 @@
  the logcheck database (although backups will be preserved). Make sure this
  is not unwanted behaviour.
  .
- Reply positively to manually write a database, or negatively to use the
+ Accept this option to manually write a database, and do not accept to use the
  database from the package "logcheck-database".
  .
  Note: since logtool does not depend on this database (but instead
@@ -59,7 +59,7 @@
 Template: logtool/map-level-to-file
 Type: select
 _Choices: exclude, include, green, yellow, blue, magenta, cyan, brightcyan
-_Description: What do you want the ${level} level of regular expressions to do?
+_Description: Action to perform by the ${level} level of regular expressions:
  Please specify what you want to do with a line if it matches at least one
  of the regular expressions in the ${level} level database. You have the
  following options (note that regular expressions are matched on a
@@ -76,7 +76,7 @@
 
 Template: logtool/error-multiple
 Type: note
-_Description: Please do not select an action more than once
+_Description: Action selected more than once
  You have selected the action ${action} for at least ${level1} and
  ${level2}. This is invalid; please either select a unique action for each
  level, or go back and choose not to use a certain level.

Attachment: signature.asc
Description: Digital signature

Reply via email to