Control: tags -1 + patch
On Fri, Mar 03, 2023 at 03:13:15PM +0100, Emanuele Rocca wrote:
> Firefox seems to erroneously enable NEON in places where it shouldn't. Trying
> to figure out exactly where and what's the best way to address this.
Patch attached.
According to the large disclaimer in moz.build one should not touch that file
but instead modify generate_mozbuild.py. It seems to me however that changes to
the python script are not automatically applied to moz.build?
In any case with the attached patch firefox-esr builds properly for armhf and
works fine here emulating a cortex-r5f CPU.
Thanks,
ema
Index: firefox-esr-102.8.0esr/gfx/skia/moz.build
===================================================================
--- firefox-esr-102.8.0esr.orig/gfx/skia/moz.build
+++ firefox-esr-102.8.0esr/gfx/skia/moz.build
@@ -455,8 +455,6 @@ if CONFIG['INTEL_ARCHITECTURE']:
SOURCES['skia/src/opts/SkOpts_sse42.cpp'].flags += ['-msse4.2']
SOURCES['skia/src/opts/SkOpts_avx.cpp'].flags += ['-mavx']
SOURCES['skia/src/opts/SkOpts_hsw.cpp'].flags += ['-mavx2', '-mf16c', '-mfma']
-elif CONFIG['CPU_ARCH'] == 'arm' and CONFIG['CC_TYPE'] in ('clang', 'gcc'):
- CXXFLAGS += CONFIG['NEON_FLAGS']
elif CONFIG['CPU_ARCH'] == 'aarch64' and CONFIG['CC_TYPE'] in ('clang', 'gcc'):
SOURCES['skia/src/opts/SkOpts_crc32.cpp'].flags += ['-march=armv8-a+crc']
