Il giorno mar, 16/05/2006 alle 19.38 +0200, Frank Küster ha scritto:
[...]
> By the way, please don't close this bug with "applied patch by Frank
> Küster".  There's no useful information in such an entry.  Rather say
> "fixed bashism and logic error in postrm script" or something like
> that. 

Thanks for pointing all these problems.
I will change the syntax in order to work with every shell, but I
already tried with bash, dash, ksh. So I think it will work for every
shell:

~$ for i in bash dash ksh
do
echo 'if [ 1 -eq 1 -a 3 -ne 4 ]; then echo A; else echo B; fi' | $i
done
~$

The only failing shell is 'posh', but I think that posh isn't enough
mature to be used as shell. Anyway, I will change the script very soon.
I think I will change the syntax or use bash, since bash has a priority
of "required".

About the changelog entry you are right: I probably should write better
comments, but I already wrote the bug number where anyone can read a
complete explaination of the problem and the solution.

Thanks again for your comments,
Giuseppe


Reply via email to