Package: git-buildpackage
Version: 0.9.22
Severity: important
Tags: patch
X-Debbugs-Cc: h...@pexip.com

Dear Maintainer,

My gitconfig contains
[tag]
        gpgsign = true
When calling 
    gbp import-dsc --pristine-tar --no-sign-tags
I get prompted by gpg to sign my tags.
With the `--no-sign-tags` option, I would expect it to instruct git to **not** 
sign tags.
The following patch (also available 
https://github.com/pexip/os-git-buildpackage/commit/8ef3ec7880caaf167429426142b0aa965ee41dd5)
resolves the issue for me.

diff --git a/gbp/git/repository.py b/gbp/git/repository.py
index e21b19e..90c8395 100644
--- a/gbp/git/repository.py
+++ b/gbp/git/repository.py
@@ -676,6 +676,8 @@ class GitRepository(object):
         if sign:
             args += ['-s']
             args += ['-u', keyid] if keyid else []
+        else:
+            args += ['--no-sign']
         args += [name]
         args += [commit] if commit else []
         self._git_command("tag", args)

-- System Information:
Debian Release: 11.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-17-amd64 (SMP w/16 CPU threads)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages git-buildpackage depends on:
ii  devscripts             2.21.3+deb11u1
ii  git                    1:2.30.2-1
ii  man-db                 2.9.4-2
ii  python3                3.9.2-3
ii  python3-dateutil       2.8.1-6pexip3
ii  python3-pkg-resources  52.0.0-4
ii  sensible-utils         0.0.14

Versions of packages git-buildpackage recommends:
ii  cowbuilder        0.89
ii  pbuilder          0.231
ii  pristine-tar      1.49
ii  python3-requests  2.25.1+dfsg-2

Versions of packages git-buildpackage suggests:
pn  python3-notify2  <none>
ii  sudo             1.9.5p2-3
ii  unzip            6.0-26+deb11u1

-- no debconf information

Reply via email to