Hi On Wed, Apr 12, 2023 at 6:49 PM Reinhard Tartler <siret...@gmail.com> wrote: > > > > On Wed, Apr 12, 2023 at 6:41 AM Reinhard Tartler <siret...@gmail.com> wrote: >> >> Control: reassign -1 golang-github-klauspost-pgzip 1.2.5-2 >> Control: affects -1 libpod >> Control: forwarded -1 https://github.com/containers/podman/issues/15944 >> Control: severity -1 important >> > > I've prepared an MR for this at > https://salsa.debian.org/go-team/packages/golang-github-klauspost-pgzip/-/merge_requests/4 > > I'm looking for opinions whether this code change is appropriate for bookwork > at this point. >
The patch looks complicated... I can't easily understand it. So beyond the code review, I look at other facts. The patch is on upstream master branch and not tagged. So all consumers expect pdoman haven't used that. It makes me worry. Maybe we could ask upstream if they can tag a new version, to indicate they are confident about the change? -- Shengjing Zhu