Source: jackd2 Severity: normal Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: shell X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Various manpages are missing when built with /bin/sh -> dash: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/jackd2.html alsa_in.1.gz jack_bufsize.1.gz jack_connect.1.gz jack_freewheel.1.gz jack_impulse_grabber.1.gz jack_iodelay.1.gz jack_load.1.gz jack_lsp.1.gz jack_metro.1.gz jack_monitor_client.1.gz jack_netsource.1.gz jack_property.1.gz jack_samplerate.1.gz jack_showtime.1.gz jack_simple_client.1.gz jack_transport.1.gz jack_unload.1.gz jack_wait.1.gz jackrec.1.gz When built with /bin/sh -> bash, all of these manpages are built and included in the package. The attached patch fixes this by using a POSIX compatible comparison operator (e.g. = vs. ==), which consistently works with both shells. Thanks for maintaining jackd2! live well, vagrant
From c4196d81e2f92f0664251a04834791952d59a023 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Sun, 30 Apr 2023 15:52:59 -0700
Subject: [PATCH 3/5] man/fill_template: Use POSIX compatible comparison.
Bash supports == comparison, but other /bin/sh implementations may
not.
---
man/fill_template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/fill_template b/man/fill_template
index 641cab8..63642a3 100644
--- a/man/fill_template
+++ b/man/fill_template
@@ -2,7 +2,7 @@
d=""
[ -z "$SOURCE_DATE_EPOCH" ] || d="--utc --date=@$SOURCE_DATE_EPOCH"
-if [ "$2" == "True" ]; then
+if [ "$2" = "True" ]; then
for i in *.0 ; do
sed -e "s/!VERSION!/${1}/g" -e "s/!DATE!/`date $d '+%Y-%m-%d'`/g" < ${i} > ${i%%0}1
done
--
2.39.2
signature.asc
Description: PGP signature
