Package: libvdk2-dev
Version: 2.4.0-5.6
Severity: normal
Tags: patch
Forwarded: https://sourceforge.net/p/vdkbuilder/bugs/20/
X-Debbugs-Cc: m...@debian.org

Dear Michael,

At the moment vdk2 does not vendor a .pc file and instead managed lib
and cflag info via a vdk-config-2 file. This is broken for cross-build
use as it has pkg-config invocations without triplet and hence this
causes cross-build issues.

Simple solution is to use a pkg-config file for getting all necessary
cflags and libs, which also improves the build experience for everyone.
Upstream is inactive for around a decade and so it'd be nice if this
could be taken up in the debian package (the change is in no way large
or disruptive).

I've attached a patch to get the .pc file installed with libvdk2-dev,
please consider applying.

Best,
Nilesh

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-2-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN
Locale: LANG=en_IN, LC_CTYPE=en_IN (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libvdk2-dev depends on:
ii  libgtk2.0-dev  2.24.33-2
ii  libvdk2-2c2    2.4.0-5.6

libvdk2-dev recommends no packages.

Versions of packages libvdk2-dev suggests:
pn  doxygen      <none>
pn  libvdk2-doc  <none>

-- no debconf information
>From ec8f2dd20a1942d75fc61b2ec0a3ecb7d227a8c5 Mon Sep 17 00:00:00 2001
From: Nilesh Patra <nil...@debian.org>
Date: Mon, 1 May 2023 11:46:05 +0000
Subject: [PATCH] Add .pc file to the package for better cross-build support

---
 debian/libvdk2-dev.dirs |  1 +
 debian/libvdk2.pc       | 13 +++++++++++++
 debian/rules            |  1 +
 3 files changed, 15 insertions(+)
 create mode 100644 debian/libvdk2.pc

diff --git a/debian/libvdk2-dev.dirs b/debian/libvdk2-dev.dirs
index e772481..f7412ea 100644
--- a/debian/libvdk2-dev.dirs
+++ b/debian/libvdk2-dev.dirs
@@ -1 +1,2 @@
 usr/bin
+usr/lib/pkgconfig
diff --git a/debian/libvdk2.pc b/debian/libvdk2.pc
new file mode 100644
index 0000000..8aabae1
--- /dev/null
+++ b/debian/libvdk2.pc
@@ -0,0 +1,13 @@
+prefix=/usr
+exec_prefix=${prefix}
+libdir=${prefix}/lib/
+includedir=${prefix}/include
+pkglibdir=${libdir}/vdk
+
+Name: libvdk2
+Description: Visual Development Kit C++ library version 2
+Requires: gtk+-x11-2.0 gtk+-x11-2.0
+Version: 2.4.0
+Libs: -L${libdir} -lvdk2 -lpthread
+Libs.private: -lpthread
+Cflags: -I${includedir}/vdk2
diff --git a/debian/rules b/debian/rules
index b995da7..5b27888 100755
--- a/debian/rules
+++ b/debian/rules
@@ -138,6 +138,7 @@ libvdk2-dev: build
        # Add here commands to install the files from debian/libvdk2-2c2
        dh_movefiles -plibvdk2-dev --sourcedir=debian/libvdk2-2c2
        cp vdk-config-2 debian/libvdk2-dev/usr/bin
+       cp debian/libvdk2.pc debian/libvdk2-dev/usr/lib/pkgconfig
 
        # start copying the examples 
        # here we do something not very clean, but it is working
-- 
2.40.0

Reply via email to