Control: retitle -1 hw-detect: firmware file path handling is fragile Control: clone -1 -2 Control: reassign -2 src:linux Control: retitle -2 brcmfmac: firmware filename inconsistency with linux-firmware.git
On Wed, 3 May 2023 at 00:34, Cyril Brulebois <k...@debian.org> wrote: > > James Addison <j...@jp-hosting.net> (2023-05-02): > It looks to me someone should understand the Linux kernel code, and > possibly where inputs/variables come from (there might be stuff coming > from the DTB, some bootloader thing, etc.), and why spaces show up in > there. Then decide whether the “external” source (if any!) or the kernel > should be adjusted to use more straightforward names. Thanks - OK. I think that the vendor name is coming from a DMI fallback: https://sources.debian.org/src/linux/6.1.25-1/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c/?hl=487#L487 Whether the model name is from DMI or from the DTS file's 'model' field is less clear to me: https://sources.debian.org/src/linux/6.1.25-1/arch/arm/boot/dts/bcm2711-rpi-400.dts/#L7 I'll try to rebuild the kernel module and test some changes 'soon' (within the next few days, most likely). Also, to clarify an error/thinko in my previous message: the style of filename we agreed to map to, and that both linux-firmware.git and the RPi operating system distro[1] use, is "brcmfmac43456-sdio.raspberrypi,400.txt" (not the short-format "brcmfmac43455-sdio.txt" that I mentioned). We should include specificity for vendor and model in the filename, all lowercased, and without spaces. The RPi 400 model firmware files are not yet represented in linux-firmware.git, although they do appear in the RPi operating system distro. Thanks, James [1] - http://archive.raspberrypi.org/debian/dists/bullseye/main/binary-arm64/Packages