Sebastian Andrzej Siewior, le mar. 09 mai 2023 22:17:21 +0200, a ecrit: > On 2023-05-06 15:49:33 [+0200], Samuel Thibault wrote: > > debian/rules is passing --enable-assembler=x86_64 to configure, but that > > case was removed, see ChangeLog: > > > > commit ac10b1b3622e70881595586edfb8a3ebdcd76bb6 > > Author: Lasse Collin <lasse.col...@tukaani.org> > > Date: 2022-11-14 17:58:07 +0200 > > > > Build: Omit x86_64 from --enable-assembler. > > > > It didn't do anything. There are only 32-bit x86 assembly files > > and it feels likely that new files won't be added as intrinsics > > in C are more portable across toolchains and OSes. > > > > The attached patch fixes that by dropping that option, since it's not > > useful for amd64 ports anyway. > > So this is a simple clean up right? No function change? At least this is > what it looks like based on your description and options I've been > looking at. I'm a little confused with "Fix hurd-amd64 build" since it > should be a nop there, right?
My patch is not a nop. Previously to Lasse's commit, the --enable-assembler=x86_64 option would make no difference from --enable-assembler=no. With Lasse's commit, --enable-assembler=x86_64 is now *refused* by ./configure. And thus amd64 builds break... But only on hurd, because that's only where debian/rules passes an --enable-assembler option at all. Samuel
