Source: nss Version: 2:3.89-2 Severity: minor Tags: patch User: helm...@debian.org Usertags: rebootstrap
Hi, every now and then nss, fails to build from source when built with the next toolchain version due to employing -Werror by default. This is unfortunate for architecture bootstrap, which tends to use bleeding edge toolchains. An example of such a bug is #984258. As a consequence debian-de...@lists.debian.org discussed ways around this limitation in the thread at https://lists.debian.org/debian-devel/2023/02/msg00276.html. The conclusion was that passing -Wno-error via DEB_CFLAGS_APPEND was an existing interface that should be easy enough to follow. As such, I am asking nss to support this interface. Thus regular builds can continue to default to -Werror while bootstrap builds have a standardized mechanism to opt out of it. I'm attaching a patch for your convenience. Helmut
diff --minimal -Nru nss-3.89/debian/changelog nss-3.89/debian/changelog --- nss-3.89/debian/changelog 2023-03-17 00:46:46.000000000 +0100 +++ nss-3.89/debian/changelog 2023-05-14 21:15:40.000000000 +0200 @@ -1,3 +1,10 @@ +nss (2:3.89-2.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Support DEB_CFLAGS_APPEND=-Werror. (Closes: #-1) + + -- Helmut Grohne <hel...@subdivi.de> Sun, 14 May 2023 21:15:40 +0200 + nss (2:3.89-2) unstable; urgency=medium * nss/lib/ssl/sslinfo.c, nss/lib/ssl/sslt.h, diff --minimal -Nru nss-3.89/debian/rules nss-3.89/debian/rules --- nss-3.89/debian/rules 2022-08-23 23:57:38.000000000 +0200 +++ nss-3.89/debian/rules 2023-05-14 21:15:32.000000000 +0200 @@ -74,8 +74,9 @@ $(NULL) # Disable -Werror on less mainline architectures. -ifneq (,$(filter-out i386 x86_64 aarch64,$(DEB_HOST_GNU_CPU))) +ifneq (,$(filter-out i386 x86_64 aarch64,$(DEB_HOST_GNU_CPU))$(filter -Wno-error,$(CFLAGS))) COMMON_MAKE_FLAGS += NSS_ENABLE_WERROR=0 +CFLAGS := $(filter-out -Wno-error,$(CFLAGS)) endif NSS_TOOLS := \