On Tue, Jun 27, 13:05, Vagrant Cascadian wrote:

> The build path is embedded in /usr/bin/lopsubgen:
> 
>   
> https://tests.reproducible-builds.org/debian/rb-pkg/trixie/amd64/diffoscope-results/liblopsub.html
> 
>   /build/1st/liblopsub-1.0.3/lopsubgen.c:49
>   vs.
>   /build/2/liblopsub-1.0.3/2nd/lopsubgen.c:49
> 
> The attached patch fixes this by passing the -ffile-prefix-map argument
> to the compiler in the upstream Makefile.
> 
> According to my local tests, with this patch and the recently submitted
> timestamp patches applied, liblopsub should build reproducibly on
> tests.reproducible-builds.org!

I'm fine with making this change. However, the patch does not apply
to current master because it depends on the previous patches (which
don't apply). This is trivial to fix, though, as shown below. Do you
want me to apply this modified patch?

Thanks
Andre
---
commit 0a3588cdf56966a58decbbf62793dcc90217651c
Author: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date:   Tue Jun 27 23:04:56 2023 +0200

    Makefile: Add -ffile-prefix-map to CC to avoid embedding build paths.
    
    Signed-off-by: Andre Noll <m...@tuebingen.mpg.de>

diff --git a/Makefile b/Makefile
index 548c96f..97d135a 100644
--- a/Makefile
+++ b/Makefile
@@ -28,6 +28,8 @@ INSTALL := install
 GZIP := gzip -fn9
 ZCAT := zcat
 
+CC += -ffile-prefix-map=$(CURDIR)=.
+
 dummy != $(M4) /dev/null || printf 'failed'
 ifeq ($(dummy), failed)
 $(error m4 is required to build this package)
-- 
Max Planck Institute for Biology
Max-Planck-Ring 5, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829
http://people.tuebingen.mpg.de/maan/

Attachment: signature.asc
Description: PGP signature

Reply via email to