Package: release.debian.org Severity: normal Tags: bookworm User: release.debian....@packages.debian.org Usertags: pu X-Debbugs-Cc: debianb...@s3lph.me Control: affects -1 + src:schleuder-cli
Dear release team, [ Reason ] Ruby 3.1, as shipped in bookworm, changes the way values are escaped, in contrast to Ruby <= 3.0. This was fixed upstream in schleuder-cli quite some time ago, but so far not released. The patch was pulled into Debian unstable via 0.1.0-5. [ Impact ] Severe, as schleuder-cli ceases to work, and throws a traceback due to an "undefined method". [ Tests ] Tests were done both manually and via the upstream CI. The correctness of the patch was confirmed via #1040257. [ Risks ] There should be none. [ Checklist ] [x] *all* changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in stable [x] the issue is verified as fixed in unstable [ Changes ] An upstream patch was pulled in to correctly handle escaping values in Ruby 3.1. For details, see the attached debdiff of 0.1.0-4, as currently present in bookworm, and 0.1.0-4+deb12u1. Thanks for your work! Cheers, Georg
diff -Nru schleuder-cli-0.1.0/debian/changelog schleuder-cli-0.1.0/debian/changelog --- schleuder-cli-0.1.0/debian/changelog 2021-02-01 22:47:06.000000000 +0000 +++ schleuder-cli-0.1.0/debian/changelog 2023-07-10 16:06:00.000000000 +0000 @@ -1,3 +1,11 @@ +schleuder-cli (0.1.0-4+deb12u1) bookworm; urgency=medium + + * debian/patches: + - Pull in upstream patch to fix escaping values in Ruby 3. + (Closes: #1040257) + + -- Georg Faerber <ge...@debian.org> Mon, 10 Jul 2023 16:06:00 +0000 + schleuder-cli (0.1.0-4) unstable; urgency=medium [ Utkarsh Gupta ] diff -Nru schleuder-cli-0.1.0/debian/patches/0004-Ruby-3-fix-escaping-values.patch schleuder-cli-0.1.0/debian/patches/0004-Ruby-3-fix-escaping-values.patch --- schleuder-cli-0.1.0/debian/patches/0004-Ruby-3-fix-escaping-values.patch 1970-01-01 00:00:00.000000000 +0000 +++ schleuder-cli-0.1.0/debian/patches/0004-Ruby-3-fix-escaping-values.patch 2023-07-10 16:06:00.000000000 +0000 @@ -0,0 +1,31 @@ +Description: Ruby 3: fix escaping values +Origin: https://0xacab.org/schleuder/schleuder-cli/-/commit/68754cf94cc2d9b2a400ff19d2e48a7ffa2ec1f2 +Reviewed-by: Georg Faerber <ge...@debian.org> +Last-Update: 2023-07-10 +--- +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ +Index: schleuder-cli/lib/schleuder-cli.rb +=================================================================== +--- schleuder-cli.orig/lib/schleuder-cli.rb 2023-07-10 15:42:53.037304520 +0000 ++++ schleuder-cli/lib/schleuder-cli.rb 2023-07-10 15:42:53.029303960 +0000 +@@ -3,6 +3,7 @@ + require 'pathname' + require 'net/https' + require 'uri' ++require 'cgi' + require 'singleton' + require 'yaml' + require 'base64' +Index: schleuder-cli/lib/schleuder-cli/helper.rb +=================================================================== +--- schleuder-cli.orig/lib/schleuder-cli/helper.rb 2023-07-10 15:42:53.037304520 +0000 ++++ schleuder-cli/lib/schleuder-cli/helper.rb 2023-07-10 15:42:53.029303960 +0000 +@@ -19,7 +19,7 @@ + u = "/#{args.join('/')}.json" + if params + paramstring = params.map do |k,v| +- "#{URI.escape(k.to_s)}=#{URI.escape(v.to_s)}" ++ "#{CGI.escape(k.to_s)}=#{CGI.escape(v.to_s)}" + end.join('&') + u << "?#{paramstring}" + end diff -Nru schleuder-cli-0.1.0/debian/patches/series schleuder-cli-0.1.0/debian/patches/series --- schleuder-cli-0.1.0/debian/patches/series 2021-02-01 22:47:06.000000000 +0000 +++ schleuder-cli-0.1.0/debian/patches/series 2023-07-10 16:06:00.000000000 +0000 @@ -1,3 +1,4 @@ +0004-Ruby-3-fix-escaping-values.patch 0003-gemspec-relax-thor-version.patch 0002-spec-remove-bundler.patch 0001-lib-use-require-instead-of-require-relative.patch
