Control: tag -1 fixed-upstream
On Sun, Jul 23, 2023 at 12:23:58AM +0100, Colin Watson wrote:
> On Sat, Jul 22, 2023 at 01:10:23PM +0000, Bjarni Ingi Gislason wrote:
> > In my ".manpath" for "nroff" was:
> >
> > DEFINE nroff test-nroff -b -ww -mandoc -rF=0 -P-i -rHY=0 -dAD=l
> > -rCHECKSTYLE=0 -rLL=90m
> >
> > Changing the line length with, say "export MANWIDTH=80", had no effect.
>
> I believe this can be fixed as follows:
>
> diff --git a/src/man.c b/src/man.c
> index 70d0dc7a..68515eed 100644
> --- a/src/man.c
> +++ b/src/man.c
> @@ -685,8 +685,7 @@ static int get_roff_line_length (void)
> {
> int line_length = cat_width ? cat_width : get_line_length ();
>
> - /* groff >= 1.18 defaults to 78. */
> - if ((!troff || ditroff) && line_length != 80) {
> + if (!troff || ditroff) {
> int length = line_length * 39 / 40;
> if (length > line_length - 2)
> return line_length - 2;
>
> This may be the right thing to do. However, it will mean that the -rLL
> in your ~/.manpath is always overridden, so I don't understand why
> you're going to the effort of specifying it explicitly in the first
> place if you want it to be overridden. Can you explain why you're doing
> this?
In the absence of feedback, I've gone ahead and committed this upstream,
since it doesn't seem to make sense for the -rLL to be overridden if and
only if the requested width is 80 columns.
https://gitlab.com/man-db/man-db/-/commit/39cdee4ada
--
Colin Watson (he/him) [cjwat...@debian.org]
