Hi Gunnar, Gunnar Wolf <gw...@debian.org> (2023-08-16): > [ Risks ] > The code is very simple.
Cassandra being my middle name, I'd advocate for more caution: The code change is relatively simple, but raspi-firmware hooks are not trivial… > The only risk I can think of is that the bug might still impact users > of non-Raspberry ARM systems. However, the likelihood of having it > installed is minor (due to the available hardware being different). Live images as of 12.0.0 installed all firmware packages, including that one, so that likelihood is *definitely not minor*. > [ Changes ] > Postinst will now check whether the architecture is ARM*, and exit > otherwise without doing the firmware install dance. > > [ Other info ] > A more proper fix would be to create a separate package with the wireless > Broadcom firmware. I have requested for the kernel team (maintainers of > firmware-brcm80211) to do so, but have got no positive response. I'd call that an orthogonal topic. In the extra checks department, I'd suggest making sure that once raspi-firmware is installed on say an amd64 machine, upgrading it to the proposed version makes it possible to upgrade a kernel (which has been the major pain point up to now) and also to… remove raspi-firmware. As far as I can remember from user horror stories, they couldn't even remove the package, and had to manually remove hooks under /etc before being able to finally remove the package. Pinch of salt, don't trust my memory. Cheers, -- Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/
signature.asc
Description: PGP signature