On Wed, Aug 16, 2023 at 11:46:05PM +0300, Michael Tokarev wrote:
16.08.2023 23:33, Athos Ribeiro wrote:
What are you going to build with static slirp?
I'm curious.
This bug report talks about static build of qemu-system. This is something
which
is difficult and definitely not supported upstream, - only very limited set of
options can be enabled for a static qemu-system build. Myself, I see no value
whatsoever in providing or pretending to provide static build of qemu, and will
not support this in debian.
Hi Michael,
Thank you for the quick reply.
I am not really sure what exactly the user is trying to accomplish with
their builds. However, supporting his case seems to be covered by the
debian policy in
https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-static
and the static library is 260Kb (which, on a second thought, is actually
quite large if we consider the current size of the -dev package).
There is also this thread in the qemu-devel mailing list which may be
relevant:
https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01044.html
Despite the size, are there any other downsides on supporting this here
which I am not seeing?
https://salsa.debian.org/qemu-team/libslirp/-/merge_requests/2
This MR lacks code which will grab the resulting libslirp.a so build will fail.
It's trivial to build a static library in addition to regular shared. But I
really want to understand the reasoning.
There is an entry in debian/libslirp-dev.install installing the static
library which should be enough, shouldn't it?
Still, the current HEAD of the master branch in salsa FTBFS. It seems
the offending commit is
https://salsa.debian.org/qemu-team/libslirp/-/commit/fc4544bb780d861ad982b9a4184cf3741fc51af4
The relevant bit in the failure is
../meson.build:1:0: ERROR: Unknown options: "disable_tests"
removing that option makes the builds pass again:
diff --git a/debian/rules b/debian/rules
index 85618b8..96cbd3c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,4 +4,4 @@ build-arch build-indep build clean install-indep install-arch
install binary-arc
dh $@ --buildsystem=meson+ninja
override_dh_auto_configure:
- dh_auto_configure -- --default-library=both -Ddisable_tests=$(if
$(filter nocheck,${DEB_BUILD_OPTIONS}),true,false)
+ dh_auto_configure -- --default-library=both
--
Athos Ribeiro
