Hi Andreas, Andreas Tille, on 2023-08-28: > Am Sun, Aug 27, 2023 at 11:26:32PM +0200 schrieb Étienne Mollier: > > > > -O1 -O2 -O3 > > -fPIE + no hardening OK OK OK > > -fno-PIE + no hardening OK FAIL FAIL > > -fPIE + hardening OK FAIL FAIL > > -fno-PIE + hardening OK FAIL FAIL > > Thanks a lot for creating this matrix.
The change even fixed LTO builds. :) On the other hand, well, the hardening is gone. :( The package looks to range on the performance critical side of the spectrum, so this is probably an acceptable trade-off. This is probably symptomatic of a deeper problem in the source code though, but I don't really expect to pinpoint the exact cause without help from upstream. > > I'm considering pushing an upload that goes in the direction of > > disabling hardening and enforcing PIE in the upcoming week, > > unless there are reasons to hold on, or someone is faster than > > me in uploading. > > I will probably be not faster than you. Please make sure you document > in d/rules that hardening breaks the tests. This should avoid that > someone later might simply switch on hardening since we usually do this. > (may be same for salsa-ci.yaml when you switch of the CI test there.) This is documented in d/rules. I'll also add the necessary lintian overrides and blhc markers to reduce the noise caused by the change in automated checks. Have a nice day, :) -- .''`. Étienne Mollier <[email protected]> : :' : gpg: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da `. `' sent from /dev/tty1, please excuse my verbosity `- on air: Orphaned Land - Fail
signature.asc
Description: PGP signature
