Package: fancontrol
Control: reopen -1
Control: found 1:3.6.0-8
Version: 1:3.6.0-8
Followup-For: Bug #664141

I've just experienced this behaviour on this (sid) machine,
only installed this week, where fancontrol controls the fan
of an ASRock RX 6x00 GPU card. The fan came on full speed after
leaving suspend and stayed there. The log indicates that fancontrol
had been restarted, exited with error:

Aug 30 09:48:47 isildor2 kernel: PM: suspend entry (deep)
(...)
Aug 30 09:48:56 isildor2 kernel: amdgpu 0000:2d:00.0: amdgpu: Failed to set 
manual fan control mode
(...)
Aug 30 09:48:56 isildor2 kernel: amdgpu: manual fan speed control should be 
enabled first
Aug 30 09:48:56 isildor2 kernel: amdgpu: manual fan speed control should be 
enabled first
Aug 30 09:48:56 isildor2 systemd-sleep[223073]: System returned from sleep 
state.
Aug 30 09:48:56 isildor2 fancontrol[222841]: /usr/sbin/fancontrol: line 649: 
echo: write error: Invalid argument
Aug 30 09:48:56 isildor2 fancontrol[222841]: Error writing PWM value to 
/sys/class/hwmon/hwmon1/pwm1
Aug 30 09:48:56 isildor2 fancontrol[222841]: Aborting, restoring fans...
Aug 30 09:48:56 isildor2 fancontrol[222841]: Verify fans have returned to full 
speed
Aug 30 09:48:56 isildor2 systemd[1]: fancontrol.service: Main process exited, 
code=exited, status=1/FAILURE
Aug 30 09:48:56 isildor2 systemd[1]: fancontrol.service: Failed with result 
'exit-code'.
Aug 30 09:48:56 isildor2 systemd[1]: Starting atop.service - Atop advanced 
performance monitor...
Aug 30 09:48:56 isildor2 systemd[1]: Started atop.service - Atop advanced 
performance monitor.
Aug 30 09:48:56 isildor2 systemd[1]: systemd-suspend.service: Deactivated 
successfully.

It seems that the original fix of this bug is still prone to a race condition:
the restart attempts seems to happen before the IO gets ready to accept
manual fan mode.

My fix was to add a drop in to the fancontrol.service:

[Service]
Restart=on-failure


(This might even make /lib/systemd/system-sleep/fancontrol
obsolete; bonus is that if fancontrol crashes, it will also auto-restart,
possibly saving some hardware from overheating…)


-- 
Cheers,
tobi


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 
'stable-security'), (500, 'oldstable-security'), (500, 'oldoldstable'), (500, 
'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.4.0-3-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages fancontrol depends on:
ii  init-system-helpers  1.65.2

fancontrol recommends no packages.

fancontrol suggests no packages.

-- no debconf information

Attachment: signature.asc
Description: PGP signature

Reply via email to