Hi Bernhard,
Version 1.7.3 of nfdump has been released. Can we release this version
in backports for Bookworm?
https://github.com/phaag/nfdump/releases/tag/v1.7.3
Best regards
Em 18/08/2023 19:19, Bernhard Schmidt escreveu:
Control: tags -1 confirmed upstream
Control: forward -1 https://github.com/phaag/nfsen/issues/19
Control: found -1 1.7.1-1
On 31/07/23 08:16 AM, Marcelo Gondim wrote:
Hi,
The commit you mention is quite intrusive (a lot of source cleanup mixed
with the bugfix) and does not apply to 1.7.1
So, I tested some more.
With my installation (still on Bullseye) the official backport of 1.7.1
somewhat works. A few random channels in a profile sometimes show 0 and
throw errors like
Uncompress_Block_LZO() error decompression failed in nffile.c line 342: LZO
error: -6
Unable to read appendix block of file:
/opt/nfsen/profiles-data/ECIX/ECIX-BER-in/2023/08/18/nfcapd.202308181520
Uncompress_Block_LZO() error decompression failed in nffile.c line 342: LZO
error: -6
Uncompress_Block_LZO() error decompression failed in nffile.c line 342: LZO
error: -6
Unable to read appendix block of file:
/opt/nfsen/profiles-data/ECIX/ECIX-MUC-in/2023/08/18/nfcapd.202308181520
Uncompress_Block_LZO() error decompression failed in nffile.c line 342: LZO
error: -6
Uncompress_Block_LZO() error decompression failed in nffile.c line 342: LZO
error: -6
Uncompress_Block_LZO() error decompression failed in nffile.c line 342: LZO
error: -6
ptr error - elementHeader > eor
when running a query against it, but it mostly works.
The patch you mentioned can be applied with just a single manually fixed
reject, it builds cleanly and the testsuite also works. But with this
patch it actually is worse, no data is ever created by nfprofile. No
error in the logs.
Plain 1.7.2 does not work either, same issue.
On 1.7.2 the patch you mentioned does not apply either, it has other
rejects. Looking at the changes src/lib/nffile.c had since 1.7.2 has
been released I would not be comfortable to do this.
The current git head appears to work fine, but that's not an option for
stable.
Looking at the commits I think it's virtually impossible to get a clean
"this minimally intrusive commit fixes the bug on top of the 1.7.1 in
stable", so I believe the only viable option would be
- upload current snapshot to unstable fixing this bug
- as soon as there is a 1.7.3 release, upload that and provide a
bookworm-backport for people using nfsen
Bernhard
