Hello Stefan, On Thu, Sep 07, 2023 at 03:19:51PM +0200, Stefan Sterz wrote: > the unit file "fcoe-utils.service" included in this package contains > these two lines: > > After=lldpad.service > Before=network.target > > The package lldpad's "lldpad.service" unit file states this: > > After=network.target > > This leads to a circular dependency where systemd can't start > fcoe-utils.service after lldpad.service and before network.target while > also starting lldpad.service after network.target. Hence, systemd breaks > this circular dependency by not starting one of the services. > > If I understand correctly, to reliably be able to start both services, > one of these dependencies needs to be changed. From what I can tell, > from the Github repository, fcoe-utils.service should be started after > network.target [1]. The unit file there includes this "After" line: > > After=syslog.target network.target
Thank you for the bug report. My initial instinct is to use the same unit file and service dependencies as upstream. Looking at the history of Debian's patch [2] of the unit file, and specifically this commit [3], it appears that the change was made to resolve an issue. The patch to the systemd unit file predates my involvement with this package, so Valentin may be able to provide more context. Perhaps there was a bug in fcoe-utils that necessitated the change at that time, but we can now revert to the unit file patch? Valentin, do you have any insight on this? Without a link to the original bug, I'm unsure what regression reverting to the upstream unit file dependencies might cause. Cheers, tony [1]: https://github.com/openSUSE/fcoe-utils/blob/master/etc/systemd/fcoe.service [2]: https://salsa.debian.org/fcoe-team/fcoe-utils/-/commits/master/debian/patches/fix-systemd-service.patch [3]: https://salsa.debian.org/fcoe-team/fcoe-utils/-/commit/1519b5cdd46710bf8f19e8662aa0999023c8cabb
signature.asc
Description: PGP signature
