Source: network-manager-iodine Version: 1.2.0-3.2 Severity: wishlist Tags: patch User: bi...@debian.org Usertags: nm-libexec
Hi, your package installs helper binaries that are currently located in /usr/lib/NetworkManager. Now that Debian policy allows to install such binaries into /usr/libexec, it was requested in [1] that the network-manager package is updated to use this location to align with other distros and avoid unnecessary friction. The network-manager package and the vpn packages maintained by the pkg-utopia team have been updated accordingly. For consistencies sake, please consider applying the attached patch, which moves the helper binaries to /usr/libexec. It updates the compat level to 13 as well, to get a $libexecdir which is set to /usr/libexec (and makes minimal changes to get the package build with compat level 13). Thanks, Michael [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026388
diff -Nru network-manager-iodine-1.2.0/debian/changelog network-manager-iodine-1.2.0/debian/changelog --- network-manager-iodine-1.2.0/debian/changelog 2022-12-30 11:19:28.000000000 +0100 +++ network-manager-iodine-1.2.0/debian/changelog 2023-10-21 12:36:31.000000000 +0200 @@ -1,3 +1,12 @@ +network-manager-iodine (1.2.0-3.3) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Install helper binaries into /usr/libexec (Closes: #-1) + * Bump debhelper-compat to 13 so libexecdir is set properly. + * Remove libtool .la files to not make dh_missing fail. + + -- Michael Biebl <bi...@debian.org> Sat, 21 Oct 2023 12:36:31 +0200 + network-manager-iodine (1.2.0-3.2) unstable; urgency=medium * Non-maintainer upload. diff -Nru network-manager-iodine-1.2.0/debian/compat network-manager-iodine-1.2.0/debian/compat --- network-manager-iodine-1.2.0/debian/compat 2021-11-17 18:27:43.000000000 +0100 +++ network-manager-iodine-1.2.0/debian/compat 1970-01-01 01:00:00.000000000 +0100 @@ -1 +0,0 @@ -9 diff -Nru network-manager-iodine-1.2.0/debian/control network-manager-iodine-1.2.0/debian/control --- network-manager-iodine-1.2.0/debian/control 2021-11-17 18:33:01.000000000 +0100 +++ network-manager-iodine-1.2.0/debian/control 2023-10-21 12:36:31.000000000 +0200 @@ -3,7 +3,7 @@ Priority: optional Maintainer: Guido Günther <a...@sigxcpu.org> Build-Depends: - debhelper (>= 9), + debhelper-compat (= 13), dpkg-dev (>= 1.16.1~), libnm-dev (>= 1.1), libnma-dev (>= 1.1), diff -Nru network-manager-iodine-1.2.0/debian/network-manager-iodine-gnome.install network-manager-iodine-1.2.0/debian/network-manager-iodine-gnome.install --- network-manager-iodine-1.2.0/debian/network-manager-iodine-gnome.install 2021-11-17 18:27:43.000000000 +0100 +++ network-manager-iodine-1.2.0/debian/network-manager-iodine-gnome.install 2023-10-21 12:36:31.000000000 +0200 @@ -1,3 +1,3 @@ +usr/libexec/nm-iodine-auth-dialog usr/lib/*/NetworkManager/*.so* -usr/lib/NetworkManager/nm-iodine-auth-dialog usr/share/gnome-vpn-properties diff -Nru network-manager-iodine-1.2.0/debian/network-manager-iodine.install network-manager-iodine-1.2.0/debian/network-manager-iodine.install --- network-manager-iodine-1.2.0/debian/network-manager-iodine.install 2021-11-17 18:28:33.000000000 +0100 +++ network-manager-iodine-1.2.0/debian/network-manager-iodine.install 2023-10-21 12:36:31.000000000 +0200 @@ -1,5 +1,5 @@ etc -usr/lib/NetworkManager/nm-iodine-service +usr/libexec/nm-iodine-service usr/lib/NetworkManager/VPN/nm-iodine-service.name usr/share/metainfo/ usr/share/locale/ diff -Nru network-manager-iodine-1.2.0/debian/rules network-manager-iodine-1.2.0/debian/rules --- network-manager-iodine-1.2.0/debian/rules 2021-11-17 18:36:06.000000000 +0100 +++ network-manager-iodine-1.2.0/debian/rules 2023-10-21 12:36:31.000000000 +0200 @@ -10,10 +10,12 @@ override_dh_auto_configure: [ -f ./configure ] || ./autogen.sh dh_auto_configure -- \ - --libexecdir=/usr/lib/NetworkManager \ --disable-static \ --without-libnm-glib \ --enable-more-warnings=yes override_dh_makeshlibs: dh_makeshlibs -X/usr/lib/$(DEB_HOST_MULTIARCH)/NetworkManager/ + +execute_before_dh_install: + find debian/tmp -name '*.la' -print -delete