Package: nodejs
Version: 18.13.0+dfsg1-1
Severity: Serious
Tags: patch
control: affects -1 src:openssl

OpenSSL 3.0.12 and 3.1.4 changed the error response resulting a failure
in test parallel/test-crypto-dh.
This has been addressed in the master branch in commit
        8eea2d3709090 ("test: fix crypto-dh error message for OpenSSL 3.x")

An additional problem is that the check compares OpenSSL from compile
time not runtime. Which means I couldn't test upstream's version as-is.
The attached version takes always the 3.0.12/3.1.4 variant. Given that
the new upload picks up the new OpenSSL vesion then it should be okay to
apply the original commit.

Sebastian
From: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
Date: Sun, 5 Nov 2023 13:08:23 +0100
Subject: [PATCH] test: Alter error message.

This is variant of upstream's commit
	8eea2d3709090 ("test: fix crypto-dh error message for OpenSSL 3.x")

It does not work as-is in Debian because the testsuite may run against a
different version than the compiled once and the constant version check
does not apply.

Signed-off-by: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
---
 test/parallel/test-crypto-dh.js      |   4 +---
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/test/parallel/test-crypto-dh.js b/test/parallel/test-crypto-dh.js
index 18721fcf289e..506780db4cbe 100644
--- a/test/parallel/test-crypto-dh.js
+++ b/test/parallel/test-crypto-dh.js
@@ -165,9 +165,7 @@ if (common.hasOpenSSL3) {
 
 assert.throws(() => {
   dh3.computeSecret('');
-}, { message: common.hasOpenSSL3 ?
-  'error:02800080:Diffie-Hellman routines::invalid secret' :
-  'Supplied key is too small' });
+}, { message: 'Supplied key is too small' });
 
 // Invalid test: curve argument is undefined
 assert.throws(
-- 
2.42.0

Reply via email to