Hi Andreas,

Andreas Tille wrote on 14/11/2023 14:55:
Hi Jörg,

thanks a lot for your bug report.

Am Mon, Nov 13, 2023 at 11:20:53AM +0100 schrieb Jörg-Volker Peetz:
after upgrading umap-learn the command

    python3 -m pip check

results in the message

   umap-learn 0.5.4 requires tbb, which is not installed.

That's an interesting finding.

Should this be addressed?

If its true I confirm it should be really be addressed.  However, I'm
not sure whether this is some outdated information.  In my clone of the
packaging Git repository I did


$ grep -Ri tbb
grep: .git/objects/pack/pack-57537d4033d776efa30645ea203ac00a96c5745b.pack: 
binary file matches
setup.py:    ] + (["tbb >= 2019.0"] if 
platform.machine().lower().startswith("x86") else []),
grep: images/densmap_example_mnist.png: binary file matches
grep: images/umap_example_fashion_mnist1.png: binary file matches


IMHO there should be some match for the string tbb somewhere else than
in setup,py which is probably checked by pip.

What do you think?

Yes, this is due to the line

tbb>=2019.0

in the file 
/usr/lib/python3/dist-packages/umap_learn-0.5.4.egg-info/requires.txt .
It's only required on x86* systems.

--
Regards,
Jörg.


Kind regards
       Andreas.


Reply via email to