Hi Colin, Thanks for the quick response. Please check my other observations, too, in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1041327#58
Cheers, Balint Colin King (gmail) <colin.i.k...@gmail.com> ezt írta (időpont: 2023. nov. 16., Cs, 11:22): > > On 15/11/2023 13:47, Bálint Réczey wrote: > > Hi Colin, > > > > There are a few upstream source files licensed under GPL. > > Please update debian/copyright to cover all the used licenses. > > Updated and uploaded -3 to mentors > > Thanks for the prompt review feedback. Much appreciated. > > Colin > > > > > You can run 'cme update dpkg-copyright' in the source directory or any > > other tool from https://wiki.debian.org/CopyrightReviewTools > > <https://wiki.debian.org/CopyrightReviewTools> to help with the manual > > labor. > > > > Cheers, > > Balint > > > > On 2023. Nov 15., Wed at 10:27, Bálint Réczey <bal...@balintreczey.hu > > <mailto:bal...@balintreczey.hu>> wrote: > > > > Hi Colin, > > > > Colin King (gmail) <colin.i.k...@gmail.com > > <mailto:colin.i.k...@gmail.com>> ezt írta (időpont: 2023. > > nov. 14., K, 17:58): > > > > > > Hi Balint, > > > > > > I've uploaded 0.4.0-2 with the suggested fixes. > > > > > > reply inlined below: > > > > > > On 09/11/2023 16:23, Bálint Réczey wrote: > > > > Hi Colin, > > > > > > > > Colin King (gmail) <colin.i.k...@gmail.com > > <mailto:colin.i.k...@gmail.com>> ezt írta (időpont: 2023. > > > > nov. 7., K, 15:18): > > > >> > > > >> Hi Balint, > > > >> > > > >> Thanks for responding with the review. I was waiting for the > > upstream > > > >> project to release a 0.4 with some minor fixes before > > re-uploading to > > > >> mentors. > > > >> > > > >> I've addressed the issues you found as below: > > > > > > > > Please see my observations below. > > > > > > > >> On 22/10/2023 22:38, Bálint Réczey wrote: > > > >>> Hi Colin, > > > >>> > > > >>> I've checked the second upload at [1]. > > > >>> As you can see in the Lintian warnings there is a .git > > directory which > > > >>> is not ideal for a source package. > > > >>> I suggest using the most widely used git-buildpackage based > > workflow > > > >>> where the gbp command takes care of exporting the source package > > > >>> without the .git dir from the packaging repository. > > > >>> I'd be happy to set up a packaging repo for you at > > > >>> https://salsa.debian.org/debian/libtypec > > <https://salsa.debian.org/debian/libtypec> and add you as a maintainer > > > >>> as described in [2] > > > > > > > > I still hold up my offer about setting up a git repo for > > packaging on > > > > Salsa. That comes with the benefit of automated fixes from Debian > > > > Janitor and I could also comment on changes right where they > > happened. > > > > > > Thank you for your kind offer; I definitely think this is a good > > idea, > > > please can you set this up for me. Much appreciated! > > > > I've created the repo at https://salsa.debian.org/debian/libtypec > > <https://salsa.debian.org/debian/libtypec> and > > added you as a maintainer. > > I've also set up CI, thus when you push your branches the pipelines > > will start. > > > > You may already be familiar with > > https://dep-team.pages.debian.net/deps/dep14/ > > <https://dep-team.pages.debian.net/deps/dep14/> , but if not, please > > check it before pushing your packaging repository. > > > > ... > > > > > > I think my comment here was misleading, sorry for that. > > > > Shipping *.pc is desired, shipping it in the .../libtypec.pc/ > > dir as a > > > > result of specifying .../libtypec.pc as the target dir in the > > .install > > > > file was not desired. It was even patched to have the right > > content. > > > > Please ship the .pc file in the -dev package. > > > > > > Fixed. > > > > The .pc file is now at the right location, but contains multiarch > > strings which will differ across architectures. > > I suggest hardcoding the paths in the patch. > > > > ... > > > > > > * As you switched back to use upstream's 0.4.0 SO version the > > .symbols > > > > file became wrong not matching the shipped SO version. Please fix > > > > that and also switch to the libtypec0 package name since it > > needs to > > > > match upstream's major SO version > > > > > > Fixed. > > > > The .symbols file's first line should be: > > libtypec.so.0 libtypec0 #MINVER# > > > > See deb-symbols(5) for more details. > > > > > . > > > > > > > > * I'd recommend asking upstream to switch to semantic SO versioning > > > > instead of using the project's version and switching to major > > version > > > > 1 when the API stabilized. > > > > > > Good idea. Will do when API changes and stabilizes. > > > > Great! > > > > Cheers, > > Balint > > > > > Colin > > > > > > > > > > > Cheers, > > > > Balint > > > > > > > >> Kind regards, > > > >> > > > >> Colin > > > >> > > > >> > > > >>> Cheers, > > > >>> Balint > > > >>> > > > >>> [1] https://mentors.debian.net/package/libtypec/ > > <https://mentors.debian.net/package/libtypec/> > > > >>> [2] > > > > https://wiki.debian.org/Salsa/Doc#Collaborative_Maintenance:_.22Debian.22_group > > > > <https://wiki.debian.org/Salsa/Doc#Collaborative_Maintenance:_.22Debian.22_group> > > > >>> > > > >>> On Thu, 3 Aug 2023 17:00:58 +0100 "Colin King (gmail)" > > > >>> <colin.i.k...@gmail.com <mailto:colin.i.k...@gmail.com>> wrote: > > > >>>> Hi, > > > >>>> > > > >>>> I've uploaded a fixed package that addresses these issues. > > > >>>> > > > >>>> Colin > > > >>>> > > > >>>> On 18/07/2023 08:50, Adam Borowski wrote: > > > >>>>> On Mon, Jul 17, 2023 at 03:29:13PM +0100, Colin King > > (gmail) wrote: > > > >>>>>> * Package name : libtypec > > > >>>>>> Version : 0.3-1 > > > >>>>>> * URL : > > https://github.com/Rajaram-Regupathy/libtypec > > <https://github.com/Rajaram-Regupathy/libtypec> > > > >>>>> > > > >>>>>> libtypec1 - generic interface for efficient USB-C > > port management > > > >>>>>> libtypec-dev - Development files for an interface for > > USB-C port management > > > >>>>> > > > >>>>>> libtypec (0.3-1) unstable; urgency=low > > > >>>>>> . > > > >>>>>> * Initial release (Closes: #1023477) > > > >>>>>> * Add patch 0001-fix-libtypec-so-version.patch to > > fix .so name version > > > >>>>> > > > >>>>> Hi! > > > >>>>> Before doing manual review, let's start with lintian: > > > >>>>> > > > >>>>> E: libtypec1: pkg-config-multi-arch-wrong-dir full text > > contains architecture specific dir x86_64-linux-gnu > > [usr/share/pkgconfig/libtypec.pc] > > > >>>>> W: libtypec-dev: empty-binary-package > > > >>>>> W: libtypec1: lacks-unversioned-link-to-shared-library > > example: usr/lib/x86_64-linux-gnu/libtypec.so > > [usr/lib/x86_64-linux-gnu/libtypec.so.0.3.0] > > > >>>>> W: libtypec1: link-to-shared-library-in-wrong-package > > usr/lib/x86_64-linux-gnu/libtypec.so.0.3.0 > > [usr/lib/x86_64-linux-gnu/libtypec.so] > > > >>>>> > > > >>>>> > > > >>>>> Meow! > > > >>>> > > > >>>> > > > >>>> > > > >>> > > > >> > > > >> > > > > > >