On dinsdag 12 december 2023 18:44:25 CET you wrote:
> Please update sway to work with wlroots 0.17. 0.17.0 is currently in
> experimental an will be uploaded to unstable by the end of December 2023.

FYI: I looked a bit into this issue and after having applied 1 upstream commit 
and backported a second, I got the following compile error:

```
../sway/lock.c: In function ‘handle_output_commit’:
../sway/lock.c:53:18: error: ‘struct wlr_output_event_commit’ has no member 
named ‘committed’
   53 |         if (event->committed & (
      |                  ^~
../sway/lock.c: In function ‘destroy_lock_surface’:
../sway/lock.c:69:65: error: ‘struct wlr_session_lock_surface_v1’ has no 
member named ‘mapped’
   69 |                         if (other != surf->lock_surface && other-
>mapped) {
      |                                                                 ^~
../sway/lock.c: In function ‘handle_new_surface’:
../sway/lock.c:114:44: error: ‘struct <anonymous>’ has no member named ‘map’
  114 |         wl_signal_add(&lock_surface->events.map, &surf->map);
      |                                            ^
../sway/lock.c:120:50: error: ‘struct <anonymous>’ has no member named ‘mode’
  120 |         wl_signal_add(&output->wlr_output->events.mode, &surf-
>output_mode);
```

After backporting the second I got a bad _feeling_ that this strategy may be 
used to get it to compile, but would that still make it run (properly)?

The 'map' issue may be fixed by backporting the following commit:
https://github.com/swaywm/sway/commit/c9e1dab3187d22ada0232d699e759a628e0ed185
but this is quite an extensive one.

While researching this I also noticed several commits titled
"chase wlroots ..." like commit 6f6b82793d95e3c10d54bcf21ca3f0c76c44b882 
referencing an upstream wlroots MR with the 'breaking' label attached to it.

At this point I decided to stop my efforts and just share my findings.

The upstream v1.9 branch contains several of those "chase wlroots ..." commits 
and mason.build targets wlroots >= 0.17 (and < 0.18).
But there are still 3 open (vs 6 closed) issues wrt '1.9' milestone and (thus) 
I have no idea when that will be released.

https://salsa.debian.org/diederik/sway/-/commits/wlroots-0.17 contains the 
things I've done so far.

HTH

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to