Hi Maytham, Thanks a lot for this and I really appreciate it, especially considering it has been a while (~6weeks) since I've sent this RFS.
Thank you for DH_GOLANG_EXCLUDES, that was what I was looking for, but couldn't get any answers from anyone before. This also helped removing the DH_GOLANG_INSTALL_EXTRA in entirety. I found your other suggestions just as valid and reasonable, and have applied all of them. Thanks a lot for the review! Now, I'd appreciate if there is someone who could sponsor this in the go team. That includes uploading the two dependencies of this; apenella-go-common-utils and sossedoff-vault-go. Hoping to find a sponsor this time. Best, Ananthu On 16 December 2023 5:57:20 am IST, Maytham Alsudany <maytha8the...@gmail.com> wrote: >Hi weepingclown, > >I've had a look at your three packages, and everything you've done is perfect. > >Some feedback regarding apanella-go-ansible: > > * Formatting: inconsistent indenting in d/control's B-Deps field > > * Instead of removing usr/bin after dh_auto_install, I recommend you use > dh-golang's settings to do that instead. Have a look at the > Debian::Debhelper::Buildsystem::golang manpage, specifically > DH_GOLANG_EXCLUDES and DH_GOLANG_EXCLUDES_ALL env vars. > > * Is examples/ansibleplaybook-simple-embedfs/embedfs/ > necessary in DH_GOLANG_INSTALL_EXTRA? > > * You may want to rename d/examples to > d/golang-github-apanella-go-ansible-dev.examples > >I question the need for stretchr-testify in the Depends field, but if other >packages have it, then no worries. > >Kind regards >Maytham
